Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • compiler
  • translator
  • TranslatorMetal.cpp
Find file
BlameHistoryPermalink
  • Tim Van Patten's avatar
    Revert "Vulkan: Let shader use rotation specialized constant" · c3607098
    Tim Van Patten authored Nov 11, 2020
    This reverts commit 47b3db22.
    
    Reason for revert:
    Broke the ANGLE roll into Chromium:
    https://chromium-review.googlesource.com/c/chromium/src/+/2531069
    
    [1875/27343] SOLINK ./libGLESv2.so
    FAILED: libGLESv2.so libGLESv2.so.TOC 
    /b/s/w/ir/cipd_bin_packages/cpython/bin/python "../../build/toolchain/gcc_solink_wrapper.py" --readelf="readelf" --nm="nm"  --sofile="./libGLESv2.so" --tocfile="./libGLESv2.so.TOC" --output="./libGLESv2.so" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared -Wl,-soname="libGLESv2.so" -Wl,--fatal-warnings -Wl,--build-id -fPIC -Wl,-z,noexecstack -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed -fuse-ld=lld -Wl,--color-diagnostics -Wl,--no-call-graph-profile-sort -m64 -Werror -nostdlib++ --sysroot=../../build/linux/debian_sid_amd64-sysroot -L../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath=\$ORIGIN -Wl,--export-dynamic -Wl,-rpath=\$ORIGIN -o "./libGLESv2.so" @"./libGLESv2.so.rsp"
    ld.lld: error: undefined symbol: sh::TranslatorVulkan::GetDriverUniformFlipXYRef(sh::TVariable const*)
    >>> referenced by RewriteDfdy.cpp:134 (../../third_party/angle/src/compiler/translator/tree_ops/RewriteDfdy.cpp:134)
    >>>               translator/RewriteDfdy.o:(sh::(anonymous namespace)::Traverser::visitUnaryWithRotation(sh::Visit, sh::TIntermUnary*)) in archive obj/third_party/angle/libtranslator.a
    >>> referenced by RewriteDfdy.cpp:200 (../../third_party/angle/src/compiler/translator/tree_ops/RewriteDfdy.cpp:200)
    >>>               translator/RewriteDfdy.o:(sh::(anonymous namespace)::Traverser::visitUnaryWithoutRotation(sh::Visit, sh::TIntermUnary*)) in archive obj/third_party/angle/libtranslator.a
    
    ld.lld: error: undefined symbol: sh::TranslatorVulkan::GetDriverUniformFragRotationMatrixRef(sh::TVariable const*)
    >>> referenced by RewriteDfdy.cpp:136 (../../third_party/angle/src/compiler/translator/tree_ops/RewriteDfdy.cpp:136)
    >>>               translator/RewriteDfdy.o:(sh::(anonymous namespace)::Traverser::visitUnaryWithRotation(sh::Visit, sh::TIntermUnary*)) in archive obj/third_party/angle/libtranslator.a
    clang: error: linker command failed with exit code 1 (use -v to see invocation)
    
    
    Original change's description:
    > Vulkan: Let shader use rotation specialized constant
    >
    > If use rotation specialized constant is enabled via compiler options,
    > this CL will use rotation specialized constant to generate flipXY,
    > rotation matrix and negFlipXY. This allows the driver to optimize for
    > the minimum instructions for rotation.
    >
    > Bug: b/171750979
    > Change-Id: I9851ac999d4d35b9f230f796e5445bca0dcb1e77
    > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2514773
    > Commit-Queue: Charlie Lao <cclao@google.com>
    > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
    > Reviewed-by: Ian Elliott <ianelliott@google.com>
    > Reviewed-by: Jamie Madill <jmadill@chromium.org>
    > Reviewed-by: Tim Van Patten <timvp@google.com>
    
    TBR=ianelliott@google.com,timvp@google.com,syoussefi@chromium.org,jmadill@chromium.org,cclao@google.com
    
    Change-Id: Id3976259d1f4049aa62b679ad5b25c2ac337c92b
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: b/171750979
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2532702Reviewed-by: 's avatarTim Van Patten <timvp@google.com>
    Commit-Queue: Tim Van Patten <timvp@google.com>
    c3607098
TranslatorMetal.cpp 13.5 KB
EditWeb IDE
×

Replace TranslatorMetal.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.