Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • gl_tests
  • VulkanPerformanceCounterTest.cpp
Find file
BlameHistoryPermalink
  • Shahbaz Youssefi's avatar
    Vulkan: Delay defining D/S content to endRenderPass · 46107d3e
    Shahbaz Youssefi authored Nov 18, 2020
    Take the following situation:
    
    1. Start RP with D/S undefined: loadOp = DONT_CARE, storeOp = STORE
      * At this point, onDepthStencilWrite calls image->onWrite, setting
        depth/stencil contents defined.
    2. At endRP, observe depth/stencil is not used: storeOp = DONT_CARE
    3. Start another RP with D/S: loadOp = LOAD, storeOp = STORE
    
    Because the call to image->onWrite was done at startRP, the contents of
    the depth/stencil image is marked as defined, and the next render pass
    is loading these data.  This change moves image->onWrite to
    endRenderPass, and only calls it if storeOp = STORE, taking advantage of
    all the opportunistic optimizations that try to set storeOp to another
    value.
    
    Bug: angleproject:4836
    Change-Id: I9858e5caa6b1f67f841a5c6356e66927356ef469
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2548319Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarCharlie Lao <cclao@google.com>
    Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
    46107d3e
VulkanPerformanceCounterTest.cpp 122 KB
EditWeb IDE
×

Replace VulkanPerformanceCounterTest.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.