Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • FrameCapture.cpp
Find file
BlameHistoryPermalink
  • Tim Van Patten's avatar
    Capture/Replay: Don't force built-in attribs to have a location · e09e947d
    Tim Van Patten authored Dec 29, 2020
    CaptureMidExecutionSetup() hits an assert while capturing "World War
    Doh":
    
      ANGLE   : FATAL: FrameCapture.cpp:2876 (CaptureMidExecutionSetup):
        ! Assert failed [[[...]]] attrib.location != -1
    
    This is due to CaptureMidExecutionSetup() enforcing that all attributes,
    including built-ins, have a location. However, in the case of "World War
    Doh", the built-in 'gl_GlobalInvocationID' does not have a location.
    
    Moving the assert to after the gl::IsBuiltInName() check allows the
    capture to complete without hitting any asserts.
    
    Bug: angleproject:4048
    Test: Capture "World War Doh"
    Change-Id: Ice96dec629b1477b11a710283c4ec4bf1c95c6e2
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606807Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarCody Northrop <cnorthrop@google.com>
    Commit-Queue: Tim Van Patten <timvp@google.com>
    e09e947d
FrameCapture.cpp 185 KB
EditWeb IDE
×

Replace FrameCapture.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.