Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • FrameCapture.cpp
Find file
BlameHistoryPermalink
  • Tim Van Patten's avatar
    Capture/Replay: Capture glBindBufferBase during MEC setup · 2d1406a8
    Tim Van Patten authored Dec 29, 2020
    "World War Doh" binds uniform buffers via glBindBufferBase() calls
    before any frames have rendered and then uses those bound buffers for
    all subsequent frames. ANGLE's frame capture was failing to perform
    these calls during the mid-execution capture setup phase, leading to
    the replay generating VVL errors:
      VUID-vkCmdDispatch-None-02699
      Descriptor in binding #0 index 0 is being used in draw but has never
      been updated via vkUpdateDescriptorSets() or a similar call.
    
    This CL adds those calls to the MEC setup phase, allowing the replay to
    execute without any errors.
    
    Bug: angleproject:5495
    Test: angle_perftests --gtest_filter="*world_war_doh*"
    Change-Id: I751c9c6f60bf78c13428a9d1d6a06dbfe600c24b
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606806Reviewed-by: 's avatarCody Northrop <cnorthrop@google.com>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Commit-Queue: Tim Van Patten <timvp@google.com>
    2d1406a8
FrameCapture.cpp 187 KB
EditWeb IDE
×

Replace FrameCapture.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.