Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • Program.cpp
Find file
BlameHistoryPermalink
  • Steven An's avatar
    Properly fail upon program binary version mismatch · ff5f715e
    Steven An authored Jan 19, 2021
    Return angle::Result::Stop instead of Incomplete when
    Program::deserialize detects version mismatch. This causes the caller,
    Program::loadBinary, to stop trying to load it. At least with the
    Vulkan backend, trying to load it results in a crash.
    
    Added test case to ProgramBinariesAcrossPlatforms which exhibits the
    old crash.
    
    Bug: angleproject:5567
    Change-Id: I2ebb27cee0aa895855504f758992b4dfec3f4aa3
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2639078Reviewed-by: 's avatarJonah Ryan-Davis <jonahr@google.com>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Commit-Queue: Steven An <stevenan@google.com>
    ff5f715e
Program.cpp 169 KB
EditWeb IDE
×

Replace Program.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.