Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • gl_tests
  • WebGLCompatibilityTest.cpp
Find file
BlameHistoryPermalink
  • Mohan Maiya's avatar
    Allow attributes and uniforms to have the same name · 6c79df68
    Mohan Maiya authored Jan 11, 2021
    It is valid for an attribute and a uniform to have the same name
    as long as they are declared in different stages.
    
    Prior to this patch, if any shader stage declares a uniform we
    disallowed reusing that name for an attribute.
    
    From GLSL ES Spec 3.00.6, section 4.3.5:
        If a uniform variable name is declared in one stage (e.g., a vertex
        shader) but not in another (e.g., a fragment shader), then that name
        is still available in the other stage for a different use.
    
    This change allows Egginc game to work with ANGLE
    
    Bug: angleproject:5497
    Tests: angle_end2end_tests -
               *UniformVariableNameReuseAcrossStages*
               *GlobalNamesConflict*
    Change-Id: I8f5657d40a213600d6fb48f63e37e4cdbae120b2
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2608865Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org>
    Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
    6c79df68
WebGLCompatibilityTest.cpp 180 KB
EditWeb IDE
×

Replace WebGLCompatibilityTest.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.