Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • capture
  • FrameCapture.cpp
Find file
BlameHistoryPermalink
  • Cody Northrop's avatar
    Capture/Replay: Fix compressed texture level caching · 7ff605a5
    Cody Northrop authored Feb 23, 2021
    Before this commit, the following sequence would cause an assert:
    
        glCompressedTexImage2D(GL_TEXTURE_2D, 0,
                               GL_COMPRESSED_RGBA_ASTC_8x8, ...);
        glCompressedTexImage2D(GL_TEXTURE_2D, 1,
                               GL_COMPRESSED_RGBA_ASTC_8x8, ...);
    
    This is due to code we added that clears the compressed texture cache
    when it detects we already have an entry for the texture level. This is
    allowed in GL, to respecify a texture level by simply calling
    glCompressedTexImage on it again.
    
    The problem is we would clear the entire texture from the cache, not
    just the level being respecified.
    
    Test: Recapture Asphalt 8
    Bug: angleproject:5678
    Change-Id: I473d6ea1cb8823bfec680ddd78c3457b93ecc431
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2716639Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarTim Van Patten <timvp@google.com>
    Commit-Queue: Cody Northrop <cnorthrop@google.com>
    7ff605a5
FrameCapture.cpp 199 KB
EditWeb IDE
×

Replace FrameCapture.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.