Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • gl_tests
  • ClearTest.cpp
Find file
BlameHistoryPermalink
  • Ian Elliott's avatar
    Vulkan: Always write to swapchain alpha channel · 6af0c03f
    Ian Elliott authored Feb 25, 2021
    This fixes an issue with the "Ragnarok M: Eternal Love" game, which
    uses a GL_RGB8 format for its window, which is actually backed by a
    GL_RGBA8 format (a.k.a. "emulated alpha").  The game does no explicit
    clear per frame.  Therefore, ANGLE selects a render pass
    loadOp=DONT_CARE, which leaves the alpha channel undefined (0.0 on a
    Pixel 4 XL).  That causes SurfaceFlinger to show (blend or alternate
    vsyncs) what should have been covered up by the game (e.g. the Android
    launcher and live wallpaper).
    
    The solution is to prevent loadOp=DONT_CARE for emulated alpha.
    
    Test: ClearTest.ChangeFramebufferAttachmentFromRGBAtoRGB
    Test: dEQP-GLES2.functional.fbo.render.stencil_clear.tex2d_rgb_stencil_index8
    Bug: b/180139027
    Change-Id: Ied97b57c93d41326cb3294ff246691e09f316791
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2704949Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org>
    Reviewed-by: 's avatarTim Van Patten <timvp@google.com>
    Commit-Queue: Ian Elliott <ianelliott@google.com>
    6af0c03f
ClearTest.cpp 90.2 KB
EditWeb IDE
×

Replace ClearTest.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.