Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • gl_tests
  • BlitFramebufferANGLETest.cpp
Find file
BlameHistoryPermalink
  • Geoff Lang's avatar
    D3D11: Skip blits if there is no intersection of dest areas · 43cdda6a
    Geoff Lang authored Apr 19, 2021
    Blit11 would clip the destination rectangle with the destination size
    but ignore the result. gl::ClipRectangle returns false when the
    rectangles do not intersect at all, indicating the blit can be skipped.
    
    This could lead to an out-of-bounds write to the GPU memory for the
    destination texture.
    
    Mark ClipRectangle as nodiscard to prevent future issues.
    
    Bug: chromium:1199402
    Change-Id: I260e82d0917b8aa7e7887f2c9f7ed4b1a03ba785
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2836786Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Commit-Queue: Geoff Lang <geofflang@chromium.org>
    (cherry picked from commit b574643e)
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2846983Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
    43cdda6a
BlitFramebufferANGLETest.cpp 102 KB
EditWeb IDE
×

Replace BlitFramebufferANGLETest.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.