Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • util
  • posix
  • crash_handler_posix.cpp
Find file
BlameHistoryPermalink
  • Shahbaz Youssefi's avatar
    Faster stack traces on Linux · 67eb2605
    Shahbaz Youssefi authored Nov 12, 2020
    Previously addr2line was called for every symbol separately.  This was
    glacially slow as every module's debug info was repeatedly reloaded.
    With this change, contiguous symbols from the same module are batched
    together and one call to addr2line is done.
    
    Potential future optimization is to batch every symbol from the same
    module, but capture the output of addr2line calls and interleave them to
    match the stack.  For example, currently 4 calls to addr2line are made
    for the following stack trace:
    
        moduleA(+addr1)
        moduleA(+addr2)
        moduleB(+addr3)
        moduleB(+addr4)
        moduleA(+addr5)
        moduleA(+addr6)
        moduleB(+addr7)
        moduleB(+addr8)
    
    while technically only two calls are necessary.
    
    Bug: angleproject:5239
    Change-Id: I58742b85409b0b74bb87272bc63e251a2d0fe0e5
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2535682
    Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarTim Van Patten <timvp@google.com>
    67eb2605
crash_handler_posix.cpp 9.97 KB
EditWeb IDE
×

Replace crash_handler_posix.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.