Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • Context.cpp
Find file
BlameHistoryPermalink
  • Tim Van Patten's avatar
    Mark most draw modes valid when no program is bound · 4756d5e6
    Tim Van Patten authored Mar 22, 2021
    gpu_angle_passthrough_fuzzer discovered a crash when glDrawArrays() is
    called without a program bound. This was caused by assuming it's an
    error to draw certain primitive types without a program bound, which is
    incorrect. This fix is to mark all draw modes except Patches valid when
    there is no program bound. Patches is handled separately by TS
    validation.
    
    Bug: chromium:1185267
    Bug: angleproject:5483
    Test: gpu_angle_passthrough_fuzzer
    Test: SimpleOperationTest31.DrawWithoutProgramBound
    Test: KHR-GLES31.core.draw_indirect.basic-mode-*adjacency
    Change-Id: I294078b8695e0b8f36d3b7ad3c1aa71d2a275038
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2780971Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org>
    Commit-Queue: Tim Van Patten <timvp@google.com>
    4756d5e6
Context.cpp 326 KB
EditWeb IDE
×

Replace Context.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.