Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • capture
  • FrameCapture.cpp
Find file
BlameHistoryPermalink
  • Cody Northrop's avatar
    Capture/Replay: Support non-binary GLboolean · fdfb2b82
    Cody Northrop authored Apr 09, 2021
    This CL contains two changes. One to how we print out GLboolean
    values, and another to how we capture GLbooleans.
    
    According to the spec, anything non-zero can be considered
    GL_TRUE when setting state:
    
        When the type of internal state is boolean, zero integer or
        floating-point values are converted to FALSE and non-zero values
        are converted to TRUE.
    
    Dota Underlords is using 0xFF for GL_TRUE.
    
    Before the change, this manifested as:
    
        // logcat
        glColorMask(context = 4, red   = kUnknownGLenumString,
                                 green = kUnknownGLenumString,
                                 blue  = kUnknownGLenumString,
                                 alpha = GL_FALSE)
    
        // trace
        glColorMask(GL_INVALID_ENUM, GL_INVALID_ENUM, GL_INVALID_ENUM, GL_FALSE);
    
    After:
    
        // logcat
        glColorMask(context = 4, red   = 0x00FF,
                                 green = 0x00FF,
                                 blue  = 0x00FF,
                                 alpha = GL_FALSE)
    
        // trace
        glColorMask(0xFF, 0xFF, 0xFF, GL_FALSE);
    
    Test: MEC for Dota Underlords
    Bug: b/185192780
    Bug: angleproject:5857
    Change-Id: Ie53aeba8d8a40f91ee375467b325d8e6be053a98
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821947
    Commit-Queue: Cody Northrop <cnorthrop@google.com>
    Reviewed-by: 's avatarTim Van Patten <timvp@google.com>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    fdfb2b82
FrameCapture.cpp 192 KB
EditWeb IDE
×

Replace FrameCapture.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.