Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • renderer
  • vulkan
  • vk_helpers.cpp
Find file
BlameHistoryPermalink
  • Charlie Lao's avatar
    Vulkan: set DS layout before using it in the endRenderPass · 46a139ad
    Charlie Lao authored May 06, 2021
    In CommandBufferHelper::endRenderPass(), we are checking depth stencil's
    initialLayout to change storeOp to None if the layout is read only. But
    the layout was set after that check, which essentially voids the
    optimization.  This CL moves the finalizeDepthStencilImageLayout() call
    before the layout is used.
    
    This CL also moves the depth stencil loadOp/storeOp to a new function
    finalizeDepthStencilLoadStoreOp(). When depthImage gets deleted before
    renderpass ends, we could also apply the same load/store optimization
    just like we did at endRenderPass() time.
    
    Bug: b/187425444
    Change-Id: I89814274352f09cbf1f7b58a91bbaf131b983fb1
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877933Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarTim Van Patten <timvp@google.com>
    Commit-Queue: Charlie Lao <cclao@google.com>
    46a139ad
vk_helpers.cpp 304 KB
EditWeb IDE
×

Replace vk_helpers.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.