Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • common
  • system_utils_win.cpp
Find file
BlameHistoryPermalink
  • Jonah Ryan-Davis's avatar
    Reland Change to module directory when loading swiftshader ICD. · e2fc818a
    Jonah Ryan-Davis authored May 05, 2021
    This is a reland of commit 3b10dda6.
    
    Extra changes:
    Be explicit about calling GetModuleHandleA
    Do not use the general GetModuleHandle, which may use wide strings
    Refactored ConcatenatePath and add tests
    
    GetModuleDirectory should return the full path, not relative.
    ANGLE wasn't able to locate the vulkan ICD file because it was
    searching down an invalid relative path. This can be fixed by
    ensuring the module directory is always the full path.
    on some platforms.
    
    Original change's description:
    > When loading vulkan, we can be running from any directory. We need
    > to change to the module directory to ensure the swiftshader ICD is
    > loaded properly. For example, in some Chrome releases, libGLESv2.dll
    > and libvk_swiftshader.dll are in a subdirectory relative to chrome.exe
    >
    > Bug: chromium:1198567
    > Change-Id: I9e68927e512b239728fb2903d1a04702508a4948
    > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2873452
    > Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
    > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
    > Reviewed-by: Jamie Madill <jmadill@chromium.org>
    
    Bug: chromium:1198567
    Bug: angleproject:5949
    Change-Id: I63fbe93f8492b7f23566f8193b1b8fe784a34f71
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2904586Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
    e2fc818a
system_utils_win.cpp 3.02 KB
EditWeb IDE
×

Replace system_utils_win.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.