Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • Context.cpp
Find file
BlameHistoryPermalink
  • Cody Northrop's avatar
    Capture/Replay: Force validation on when capturing · a44b16d3
    Cody Northrop authored May 26, 2021
    Genshin Impact is using EGL_KHR_create_context_no_error to create a
    context that exposes GL_KHR_no_error.  If it successfully creates
    the context, it sends down call sequences that check query
    results available immediately after genning query objects:
    
      glGenQueries(1, reinterpret_cast<GLuint *>(gReadBuffer));
      UpdateQueryID(415, 0);
      glGetQueryObjectuiv(gQueryMap[415], GL_QUERY_RESULT_AVAILABLE, ...);
    
    This throws errors on every platform I have access to, with either
    native or ANGLE as the driver.  The spec is ambiguous as to whether
    this should cause an error, but practically we can't allow this if we
    want error free playback of traces.
    
    To support this, we will force validation on in the context when
    FrameCapture is enabled.  When the app submits invalid calls, they
    will be dropped by FrameCapture.
    
    Test: Genshin Impact MEC
    Bug: b/181794064
    Change-Id: If882d27d74661cd95bc23687eff3056a0f64e3cc
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2921068
    Commit-Queue: Cody Northrop <cnorthrop@google.com>
    Reviewed-by: 's avatarTim Van Patten <timvp@google.com>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    a44b16d3
Context.cpp 328 KB
EditWeb IDE
×

Replace Context.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.