Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • third_party
  • compiler
  • ArrayBoundsClamper.cpp
Find file
BlameHistoryPermalink
  • Yuly Novikov's avatar
    Revert "Make SH_CLAMP_INDIRECT_ARRAY_BOUNDS do proper AST transformation" · 10f15011
    Yuly Novikov authored Jun 03, 2021
    This reverts commit a474fd7d.
    
    Reason for revert: breaks GLES2ConformTest, see roll into Chromium:
    https://chromium-review.googlesource.com/c/chromium/src/+/2935093
    
    Original change's description:
    > Make SH_CLAMP_INDIRECT_ARRAY_BOUNDS do proper AST transformation
    >
    > This translator flag adds a clamp to non-literal indices to arrays.  Two
    > strategies were provisioned, using the clamp intrinsic or a hand-written
    > function.   The latter is ununsed in angle, chromium, firefox and
    > webkit, so this change removes this option and uses the clamp intrinsic
    > unconditionally.
    >
    > The clamp itself was added at output generation time with special flags
    > set on the index node.  This is changed such that a proper AST
    > transformation is done and no-special handling would be necessary.
    >
    > Bug: angleproject:4361
    > Bug: angleproject:4889
    > Change-Id: Ieccfd2c1c347563fb5282e9fa66d39304e62f2ca
    > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2935041
    > Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
    > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
    
    Bug: angleproject:4361
    Bug: angleproject:4889
    Change-Id: I911cfe0199b04dbc3d6d4265775b6c2de00a9777
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2937024
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Reviewed-by: 's avatarYuly Novikov <ynovikov@chromium.org>
    Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
    10f15011
ArrayBoundsClamper.cpp 3.91 KB
EditWeb IDE
×

Replace ArrayBoundsClamper.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.