Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • renderer
  • vulkan
  • ImageVk.cpp
Find file
BlameHistoryPermalink
  • Tim Van Patten's avatar
    Vulkan: Cleanup garbage when destroying EGL images · 54e99d36
    Tim Van Patten authored Apr 23, 2021
    SurfaceFlinger will optimistically create EGL images just in case it
    does need them in the future, since creating them can be slow and
    waiting until they're necessary can cause jank on 90hz+ devices.
    However, since the images are never actually used, ANGLE's garbage is
    never cleaned up so vkDestroyImage() and the memory is never freed. This
    can lead to exhausting the device's memory when many EGL images are
    allocated. For example, when running the CTS test
    CtsBiometricsTestCases.
    
    This CL adds a call to always cleanup the renderer's garbage when an EGL
    image is destroyed via eglDestroyImageKHR(), since we can't know if a
    draw will ever be performed in the future (which would normally cleanup
    the garbage).
    
    Bug: b/184388756
    Test: atest CtsBiometricsTestCases
    Change-Id: I104c05c7be44f1e57123ac7eed23effaa982837a
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2848131Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarJason Macnak <natsu@google.com>
    Reviewed-by: 's avatarCharlie Lao <cclao@google.com>
    Commit-Queue: Tim Van Patten <timvp@google.com>
    54e99d36
ImageVk.cpp 5.6 KB
EditWeb IDE
×

Replace ImageVk.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.