Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • tests
  • gl_tests
  • StateChangeTest.cpp
Find file
BlameHistoryPermalink
  • Shahbaz Youssefi's avatar
    Test for missing index dirty bit bug · c51c59c7
    Shahbaz Youssefi authored Jun 15, 2021
    Bug fixed in
    https://chromium-review.googlesource.com/c/angle/angle/+/2961690
    triggers only in the following situation:
    
    - Context 1: draw indexed -> clears index dirty bit
    - Context 1: change state in such a way that closing the render pass is
                 deferred to dirty bit handling (for example, change FBO)
    - Context 1: issue a non-indexed draw call.  This closes the render pass
                 and starts a new one -> bug was that the index dirty bit
                 was not set
    - Context 2: flush the command buffer, which submits the previous render
                 pass of context 1 (which contained vkCmdBindIndexBuffer).
                 The primary command buffer is now reset.
    - Context 1: issue an indexed draw call.  Since the index dirty bit was
                 not set, this was missing the vkCmdBindIndexBuffer call.
    
    This change implements a regression test based on the above scenario.
    
    Bug: chromium:1183068
    Bug: chromium:1190493
    Change-Id: I729bd48cd6df2621ca763f6231023a52ac08b0fb
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2963836Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org>
    Reviewed-by: 's avatarCharlie Lao <cclao@google.com>
    Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
    c51c59c7
StateChangeTest.cpp 258 KB
EditWeb IDE
×

Replace StateChangeTest.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.