Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • commit_id.py
Find file
BlameHistoryPermalink
  • Shahbaz Youssefi's avatar
    Fix angle_commit.h dependency when git packs refs · 955b4620
    Shahbaz Youssefi authored Jul 01, 2021
    If there are too many files in .git/refs/heads/, git packs them in
    .git/packed-refs.  This breaks the build as gen/angle/angle_commit.h
    depends on .git/refs/heads/<branch-name>.
    
    With this change, when gn is run and the dependency to this file is set
    up, it's unpacked from .git/packed-refs if it's missing from
    .git/refs/heads/.
    
    One corner case not solved by this change is if a commit is amended with
    no changes and git packs the refs (and so the
    .git/refs/heads/<branch-name> file goes away), ninja doesn't rerun gn as
    it doesn't believe there to be any changes, yet fails the build as the
    dependency is now missing.  Running `gn gen` manually fixes the issue.
    The issue is automatically fixed when switching branches.
    
    Bug: angleproject:6131
    Change-Id: Ie2404e874a5cb3374a652b93faa143acb68eaa19
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3001906Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
    Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
    955b4620
commit_id.py 3.36 KB
EditWeb IDE
×

Replace commit_id.py

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.