Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • include
  • GLSLANG
  • ShaderVars.h
Find file
BlameHistoryPermalink
  • Tim Van Patten's avatar
    Reorder ShaderVariable functions and members · 34e28778
    Tim Van Patten authored Mar 17, 2021
    ShaderVariable's functions and members are all mixed up. This CL
    reorders things to move the functions before the members, to better
    match ANGLE's coding style.
    
    This also adds a note that any new members that are added need to be
    added to gl::WriteShaderVar() and gl::LoadShaderVar(), which are
    actually implemented in Program.cpp, since ShaderVars.h/cpp can't
    include libANGLE/BinaryStream.h. There are currently several members
    that are missing, leading to save/load errors, which are fixed in a
    follow-on CL in this chain.
    
    Bug: b/182409935
    Change-Id: I1381a5efffb56c0989961bbcfd405b95d59d6396
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770682
    Commit-Queue: Tim Van Patten <timvp@google.com>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarCody Northrop <cnorthrop@google.com>
    34e28778
ShaderVars.h 12.3 KB
EditWeb IDE
×

Replace ShaderVars.h

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.