Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libANGLE
  • renderer
  • vulkan
  • doc
  • Queries.md
Find file
BlameHistoryPermalink
  • Shahbaz Youssefi's avatar
    Vulkan: Support PrimitivesGenerated query · f691b3b5
    Shahbaz Youssefi authored Dec 02, 2020
    This query uses the Vulkan transform feedback extension.  In GL,
    GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN and GL_PRIMITIVES_GENERATED
    queries can be independently begun/ended.  However, Vulkan requires that
    queries from pools of the same type can only be active one at a time.
    This forbids the two GL queries from being handled by two VK queries
    when they are simultaneously begun.
    
    This change makes these queries share their QueryHelper objects.  The
    Vulkan transform feedback queries unconditionally retrieve both results
    anyway, so this is just a matter of making sure the two GL queries are
    merged as one when they are simultaneously used.
    
    The change fixes a number of issues as collateral:
    
    - TransformFeedbackPrimitivesWritten queries when !emulated were not
      released
    - Stashed queries were never released
    - If no render pass is open when a query ends, then getResult(no_wait)
      ended up waiting
    
    Bug: angleproject:5404
    Change-Id: I8ce13ea76ffd31b3152ded7c713c6466d0315504
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2573580
    Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
    Reviewed-by: 's avatarCharlie Lao <cclao@google.com>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    f691b3b5
Queries.md 5.8 KB
EditWeb IDE
×

Replace Queries.md

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.