Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
A
angle
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • angle
  • Repository

Switch branch/tag
  • angle
  • src
  • libGLESv2
  • entry_points_cl_utils.cpp
Find file
BlameHistoryPermalink
  • John Plate's avatar
    CL: Remove object cache and fix multi-threading · baca10b7
    John Plate authored May 29, 2021
    All CL front end objects used to be cached to be able to determine
    if an object has been created by the front end to check its validity.
    The validity is now checked with the existence of an intrinsic value
    (the dispatch table pointer), which is consistent with the patterns
    found in Mesa and clvk (though clvk uses a magic value).
    This allows the removal of all cached objects.
    
    The cached objects were stored with std::unique_ptr. These are now
    gone and all remaining pointers are now custom intrinsic reference
    count pointers.
    
    Also remove global lock which causes deadlocks, e.g. when CL API
    is called from a separate thread to unlock a blocking call with
    a user event. Most of the front end is constant and already
    thread-safe. The ref count is also thread-safe now (atomic).
    A few remaining locks will follow.
    Without the global lock it was now possible to make the API
    reentrant, and to remove the workaround with the Khronos ICD
    loader to skip ANGLE's OpenCL library.
    
    Bug: angleproject:6001
    Change-Id: I7d3b52db9011a02cb7ea9ebdeb6e22c4c702ef5b
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2927395
    Commit-Queue: John Plate <jplate@google.com>
    Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    Reviewed-by: 's avatarCody Northrop <cnorthrop@google.com>
    baca10b7
entry_points_cl_utils.cpp 1.59 KB
EditWeb IDE
×

Replace entry_points_cl_utils.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.