Skip to content

A
angle
Commit 0029dfe2 by Michael Spang Committed by Commit Bot
Options

Vulkan: Respect EGL_HEIGHT & EGL_WIDTH in SurfaceVk

If currentExtent is unspecified and EGL_WIDTH & EGL_HEIGHT are provided, we'll use a surface size of 0xFFFFFFFF. That's not going to work and appears to be a typo. Use the size specified in EGL_WIDTH & EGL_HEIGHT instead. BUG=angleproject:2475 TEST=angle_end2end_tests on Fuchsia with an earlier version of CL 1446496 PS12. It is N/A with later patches. Change-Id: I7e67b2c796318bed512dd6d5d22ef2183916416d Reviewed-on: https://chromium-review.googlesource.com/c/1461637 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
parent fe59f6b5
Showing with 2 additions and 8 deletions
src/libANGLE/renderer/vulkan/SurfaceVk.cpp
...@@ -373,14 +373,8 @@ angle::Result WindowSurfaceVk::initializeImpl(DisplayVk *displayVk) ...@@ -373,14 +373,8 @@ angle::Result WindowSurfaceVk::initializeImpl(DisplayVk *displayVk)
{ {
ASSERT(mSurfaceCaps.currentExtent.height == 0xFFFFFFFFu); ASSERT(mSurfaceCaps.currentExtent.height == 0xFFFFFFFFu);
if (attribWidth == 0) width = (attribWidth != 0) ? static_cast<uint32_t>(attribWidth) : windowSize.width;
{ height = (attribHeight != 0) ? static_cast<uint32_t>(attribHeight) : windowSize.height;
width = windowSize.width;
}
if (attribHeight == 0)
{
height = windowSize.height;
}
} }
gl::Extents extents(static_cast<int>(width), static_cast<int>(height), 1); gl::Extents extents(static_cast<int>(width), static_cast<int>(height), 1);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment