Vulkan: Use dst access masks to determine if barrier is needed

Src access mask may be 0 with WAR barriers. Bug: angleproject:5290 Change-Id: I798d4c36aa7d3d14db333a7e86794e13c8137f96 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2514841 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>

Vulkan: Use dst access masks to determine if barrier is needed
019e3f77 · Shahbaz Youssefi · Commit Bot · 61180d01 · 019e3f77
Commit 019e3f77 authored Nov 02, 2020 by Shahbaz Youssefi Committed by Commit Bot Nov 03, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 3 deletions

vk_helpers.h src/libANGLE/renderer/vulkan/vk_helpers.h +3 -3

No files found.
--- a/src/libANGLE/renderer/vulkan/vk_helpers.h
+++ b/src/libANGLE/renderer/vulkan/vk_helpers.h
@@ -627,7 +627,7 @@ class PipelineBarrier : angle::NonCopyable
    {}
    ~PipelineBarrier() = default;
-    bool isEmpty() const { return mImageMemoryBarriers.empty() && mMemoryBarrierSrcAccess == 0; }
+    bool isEmpty() const { return mImageMemoryBarriers.empty() && mMemoryBarrierDstAccess == 0; }
    void execute(PrimaryCommandBuffer *primary)
    {
@@ -639,7 +639,7 @@ class PipelineBarrier : angle::NonCopyable
        // Issue vkCmdPipelineBarrier call
        VkMemoryBarrier memoryBarrier = {};
        uint32_t memoryBarrierCount   = 0;
-        if (mMemoryBarrierSrcAccess != 0)
+        if (mMemoryBarrierDstAccess != 0)
        {
            memoryBarrier.sType         = VK_STRUCTURE_TYPE_MEMORY_BARRIER;
            memoryBarrier.srcAccessMask = mMemoryBarrierSrcAccess;
@@ -663,7 +663,7 @@ class PipelineBarrier : angle::NonCopyable
        // Issue vkCmdPipelineBarrier call
        VkMemoryBarrier memoryBarrier = {};
        uint32_t memoryBarrierCount   = 0;
-        if (mMemoryBarrierSrcAccess != 0)
+        if (mMemoryBarrierDstAccess != 0)
        {
            memoryBarrier.sType         = VK_STRUCTURE_TYPE_MEMORY_BARRIER;
            memoryBarrier.srcAccessMask = mMemoryBarrierSrcAccess;