queryutils: Handle AmbientAndDiffuse param count.

Add AmbientAndDiffuse cases for determining light and material parameter count. Define default cases as UNREACHABLE for GetLightModelParameterCount, GetLightParameterCount and GetMaterialParameterCount. Bug: angleproject:5751 Change-Id: I58acb62e66cea71277654313800dafa57c42b17e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2871794Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>

queryutils: Handle AmbientAndDiffuse param count.
01b05333 · Lubosz Sarnecki · Commit Bot · c034d045 · 01b05333
Commit 01b05333 authored May 04, 2021 by Lubosz Sarnecki Committed by Commit Bot May 06, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 0 deletions

queryutils.cpp src/libANGLE/queryutils.cpp +5 -0

No files found.
--- a/src/libANGLE/queryutils.cpp
+++ b/src/libANGLE/queryutils.cpp
@@ -2487,6 +2487,7 @@ unsigned int GetLightModelParameterCount(GLenum pname)
        case GL_LIGHT_MODEL_TWO_SIDE:
            return 1;
        default:
+            UNREACHABLE();
            return 0;
    }
 }
@@ -2497,6 +2498,7 @@ unsigned int GetLightParameterCount(LightParameter pname)
    {
        case LightParameter::Ambient:
        case LightParameter::Diffuse:
+        case LightParameter::AmbientAndDiffuse:
        case LightParameter::Specular:
        case LightParameter::Position:
            return 4;
@@ -2509,6 +2511,7 @@ unsigned int GetLightParameterCount(LightParameter pname)
        case LightParameter::QuadraticAttenuation:
            return 1;
        default:
+            UNREACHABLE();
            return 0;
    }
 }
@@ -2519,12 +2522,14 @@ unsigned int GetMaterialParameterCount(MaterialParameter pname)
    {
        case MaterialParameter::Ambient:
        case MaterialParameter::Diffuse:
+        case MaterialParameter::AmbientAndDiffuse:
        case MaterialParameter::Specular:
        case MaterialParameter::Emission:
            return 4;
        case MaterialParameter::Shininess:
            return 1;
        default:
+            UNREACHABLE();
            return 0;
    }
 }