Fix handling unsized arrays with incorrect initializer

src/compiler/translator/ParseContext.cpp

@@ -1484,7 +1484,17 @@ bool TParseContext::executeInitializer(const TSourceLoc &line,
     TVariable *variable = nullptr;
     if (type.isUnsizedArray())
     {
-        type.setArraySize(initializer->getArraySize());
+        // We have not checked yet whether the initializer actually is an array or not.
+        if (initializer->isArray())
+        {
+            type.setArraySize(initializer->getArraySize());
+        }
+        else
+        {
+            // Having a non-array initializer for an unsized array will result in an error later,
+            // so we don't generate an error message here.
+            type.setArraySize(1u);
+        }
     }
     if (!declareVariable(line, identifier, type, &variable))
     {

src/tests/compiler_tests/MalformedShader_test.cpp

@@ -3017,4 +3017,24 @@ TEST_F(MalformedShaderTest, FloatDeclarationNoQualifiersNoPrecision)
     {
         FAIL() << "Shader compilation succeeded, expecting failure " << mInfoLog;
     }
-}
+}
\ No newline at end of file
+
+// Check compiler doesn't crash on incorrect unsized array declarations.
+TEST_F(MalformedShaderTest, IncorrectUnsizedArray)
+{
+    const std::string &shaderString =
+        "#version 300 es\n"
+        "precision mediump float;\n"
+        "float foo[] = 0.0;\n"
+        "out vec4 my_FragColor;\n"
+        "void main()\n"
+        "{\n"
+        "    foo[0] = 1.0;\n"
+        "    my_FragColor = vec4(foo[0]);\n"
+        "}\n";
+
+    if (compile(shaderString))
+    {
+        FAIL() << "Shader compilation succeeded, expecting failure " << mInfoLog;
+    }
+}