Fix sorting uninitialized attribute semantics to the end.

A missing condition would produce a sort order where sometimes -1 was shifted to the front of the semantic array, instead of the end. BUG=angle:527 Change-Id: I69b2e5ccc03f6523771601cd59293d6cd325be2f Reviewed-on: https://chromium-review.googlesource.com/180660Reviewed-by: Nicolas Capens <nicolascapens@chromium.org> Commit-Queue: Nicolas Capens <nicolascapens@chromium.org> Tested-by: Nicolas Capens <nicolascapens@chromium.org> Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

Fix sorting uninitialized attribute semantics to the end.
0523d839 · Jamie Madill · 783a624e · 0523d839
Commit 0523d839 authored Dec 17, 2013 by Jamie Madill
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

ProgramBinary.cpp src/libGLESv2/ProgramBinary.cpp +3 -1

No files found.
--- a/src/libGLESv2/ProgramBinary.cpp
+++ b/src/libGLESv2/ProgramBinary.cpp
@@ -2592,7 +2592,9 @@ struct AttributeSorter

    bool operator()(int a, int b)
    {
-        return originalIndices[a] == -1 ? false : originalIndices[a] < originalIndices[b];
+        if (originalIndices[a] == -1) return false;
+        if (originalIndices[b] == -1) return true;
+        return (originalIndices[a] < originalIndices[b]);
    }

    const int (&originalIndices)[MAX_VERTEX_ATTRIBS];