Vulkan: Fix offsets in BufferVk::setDataImpl.

We were using a src offset instead of a dest offset. The staging buffer should always start at the zero offset, while the dest buffer (the real buffer) should use the offset argument to Buffer*Data. Bug: angleproject:2374 Change-Id: I9ee702709d9c15945935f4eae25f308b71e0d1e8 Reviewed-on: https://chromium-review.googlesource.com/937022 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Frank Henigman <fjhenigman@chromium.org>

Vulkan: Fix offsets in BufferVk::setDataImpl.
06a87ec8 · Jamie Madill · Commit Bot · d063affa · 06a87ec8
Commit 06a87ec8 authored Feb 25, 2018 by Jamie Madill Committed by Commit Bot Feb 27, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

BufferVk.cpp src/libANGLE/renderer/vulkan/BufferVk.cpp +1 -1

No files found.
--- a/src/libANGLE/renderer/vulkan/BufferVk.cpp
+++ b/src/libANGLE/renderer/vulkan/BufferVk.cpp
@@ -220,7 +220,7 @@ vk::Error BufferVk::setDataImpl(ContextVk *contextVk,
        commandBuffer->singleBufferBarrier(VK_PIPELINE_STAGE_ALL_COMMANDS_BIT,
                                           VK_PIPELINE_STAGE_TRANSFER_BIT, 0, bufferBarrier);

-        VkBufferCopy copyRegion = {offset, 0, size};
+        VkBufferCopy copyRegion = {0, offset, size};
        commandBuffer->copyBuffer(stagingBuffer.getBuffer(), mBuffer, 1, &copyRegion);

        // Immediately release staging buffer.