Commit 06de90c6 by Shahbaz Youssefi Committed by Commit Bot

Vulkan: Re-enable a handful of suppressed ES3 tests

Few features are already implemented but the suppressions were not removed. Bug: angleproject:2392 Bug: angleproject:2394 Bug: angleproject:3199 Bug: angleproject:3219 Bug: angleproject:3423 Change-Id: Iefd6c10f5ec774e174901114b35410c0d397085f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1614428 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: 's avatarYuly Novikov <ynovikov@chromium.org>
parent 0febee5b
...@@ -985,8 +985,9 @@ TEST_P(ClearTestES3, MaskedClearHeterogeneousAttachments) ...@@ -985,8 +985,9 @@ TEST_P(ClearTestES3, MaskedClearHeterogeneousAttachments)
// mistakenly clear every channel (including the masked-out ones) // mistakenly clear every channel (including the masked-out ones)
TEST_P(ClearTestES3, MaskedClearBufferBug) TEST_P(ClearTestES3, MaskedClearBufferBug)
{ {
// Vulkan doesn't support gaps in render targets yet. http://anglebug.com/2394 // TODO(syoussefi): Qualcomm driver crashes in the presence of VK_ATTACHMENT_UNUSED.
ANGLE_SKIP_TEST_IF(IsVulkan()); // http://anglebug.com/3423
ANGLE_SKIP_TEST_IF(IsVulkan() && IsAndroid());
unsigned char pixelData[] = {255, 255, 255, 255}; unsigned char pixelData[] = {255, 255, 255, 255};
...@@ -1123,9 +1124,6 @@ TEST_P(ClearTestES3, MixedSRGBClear) ...@@ -1123,9 +1124,6 @@ TEST_P(ClearTestES3, MixedSRGBClear)
// flush or finish after ClearBufferfv or each draw. // flush or finish after ClearBufferfv or each draw.
TEST_P(ClearTestES3, RepeatedClear) TEST_P(ClearTestES3, RepeatedClear)
{ {
// ES3 shaders are not yet supported on Vulkan.
ANGLE_SKIP_TEST_IF(IsVulkan());
constexpr char kVS[] = constexpr char kVS[] =
"#version 300 es\n" "#version 300 es\n"
"in highp vec2 position;\n" "in highp vec2 position;\n"
......
...@@ -2405,10 +2405,6 @@ TEST_P(GLSLTest_ES3, UnaryMinusOperatorSignedInt) ...@@ -2405,10 +2405,6 @@ TEST_P(GLSLTest_ES3, UnaryMinusOperatorSignedInt)
// Convers a bug with the unary minus operator on unsigned integer workaround. // Convers a bug with the unary minus operator on unsigned integer workaround.
TEST_P(GLSLTest_ES3, UnaryMinusOperatorUnsignedInt) TEST_P(GLSLTest_ES3, UnaryMinusOperatorUnsignedInt)
{ {
// TODO(syoussefi): missing [gs]etUniform support with unsigned formats.
// http://anglebug.com/2392
ANGLE_SKIP_TEST_IF(IsVulkan());
constexpr char kVS[] = constexpr char kVS[] =
"#version 300 es\n" "#version 300 es\n"
"in highp vec4 position;\n" "in highp vec4 position;\n"
...@@ -4407,10 +4403,6 @@ void main() ...@@ -4407,10 +4403,6 @@ void main()
// Test that a varying struct that's defined as a part of the declaration is handled correctly. // Test that a varying struct that's defined as a part of the declaration is handled correctly.
TEST_P(GLSLTest_ES3, VaryingStructWithInlineDefinition) TEST_P(GLSLTest_ES3, VaryingStructWithInlineDefinition)
{ {
// TODO(syoussefi): missing ES3 shader feature support.
// http://anglebug.com/3199
ANGLE_SKIP_TEST_IF(IsVulkan());
constexpr char kVS[] = R"(#version 300 es constexpr char kVS[] = R"(#version 300 es
in vec4 inputAttribute; in vec4 inputAttribute;
...@@ -4507,10 +4499,6 @@ void main() { ...@@ -4507,10 +4499,6 @@ void main() {
// is handled correctly. // is handled correctly.
TEST_P(GLSLTest_ES3, FlatVaryingUsedInFoldedTernary) TEST_P(GLSLTest_ES3, FlatVaryingUsedInFoldedTernary)
{ {
// TODO(syoussefi): missing ES3 shader feature support.
// http://anglebug.com/3219
ANGLE_SKIP_TEST_IF(IsVulkan());
constexpr char kVS[] = R"(#version 300 es constexpr char kVS[] = R"(#version 300 es
in vec4 inputAttribute; in vec4 inputAttribute;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment