Fix IOSurfaceClientBufferTest.RenderToBGRX8888IOSurface on OSX+OpenGL

For BGRX, the alpha value is undefined. It wont write back to client memory, so don't compare alpha to expected result. Bug: angleproject:5958 Change-Id: I289f14f7c6a6ee63e74351d6abdd44fff8bf106b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2891926Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>

Fix IOSurfaceClientBufferTest.RenderToBGRX8888IOSurface on OSX+OpenGL
07ae2970 · Charlie Lao · Commit Bot · dd686e48 · 07ae2970
Commit 07ae2970 authored May 12, 2021 by Charlie Lao Committed by Commit Bot May 14, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 12 additions and 1 deletion

EGLIOSurfaceClientBufferTest.cpp src/tests/egl_tests/EGLIOSurfaceClientBufferTest.cpp +12 -1

No files found.
--- a/src/tests/egl_tests/EGLIOSurfaceClientBufferTest.cpp
+++ b/src/tests/egl_tests/EGLIOSurfaceClientBufferTest.cpp
@@ -267,7 +267,18 @@ class IOSurfaceClientBufferTest : public ANGLETest
               sizeof(T) * data.size());
        IOSurfaceUnlock(ioSurface.get(), kIOSurfaceLockReadOnly, nullptr);
-        ASSERT_EQ(data, iosurfaceData);
+        if (internalFormat == GL_RGB && IsOSX() && IsOpenGL())
+        {
+            // Ignore alpha component for BGRX, the alpha value is undefined
+            for (int i = 0; i < 3; i++)
+            {
+                ASSERT_EQ(data[i], iosurfaceData[i]);
+            }
+        }
+        else
+        {
+            ASSERT_EQ(data, iosurfaceData);
+        }
        result = eglDestroySurface(mDisplay, pbuffer);
        EXPECT_EGL_TRUE(result);