Commit 081b6e2b by Jamie Madill Committed by Commit Bot

Extend UBO binding workaround to Android.

This seems to fail on the Nexus 6P, and possibly 5X. Does not seem to affect some other devices. BUG=angleproject:1660 Change-Id: I1d456b2033fb6b2a664ac24ea0a3f7ff160922ab Reviewed-on: https://chromium-review.googlesource.com/419856Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
parent d9671226
......@@ -115,7 +115,7 @@ struct WorkaroundsGL
// Some drivers seem to forget about UBO bindings when loading program binaries. Work around
// this by re-applying the bindings after the program binary is loaded.
// This only seems to affect AMD OpenGL drivers.
// This only seems to affect AMD OpenGL drivers, and some Android devices.
// http://anglebug.com/1660
bool reapplyUBOBindingsAfterLoadingBinaryProgram = false;
};
......
......@@ -959,6 +959,11 @@ void GenerateWorkarounds(const FunctionsGL *functions, WorkaroundsGL *workaround
workarounds->emulateAtan2Float = IsNvidia(vendor);
workarounds->reapplyUBOBindingsAfterLoadingBinaryProgram = IsAMD(vendor);
#if defined(ANGLE_PLATFORM_ANDROID)
// TODO(jmadill): Narrow workaround range for specific devices.
workarounds->reapplyUBOBindingsAfterLoadingBinaryProgram = true;
#endif
}
} // namespace nativegl_gl
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment