Remove un-needed swapBuffers calls in the tests.

If a glReadPixels is done after a swapBuffers, it's results are often undefined. bug=angleproject:967 Change-Id: I4a99ca47624347ecbc0a5c084e93b997c92e1b31 Reviewed-on: https://chromium-review.googlesource.com/272423Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Tested-by: Geoff Lang <geofflang@chromium.org>

Remove un-needed swapBuffers calls in the tests.
08a8438f · Geoff Lang · bd0d6b93 · 08a8438f · 08a8438f · 08a8438f
Commit 08a8438f authored May 20, 2015 by Geoff Lang
Hide whitespace changes
Inline Side-by-side

Showing with 0 additions and 5 deletions

GLSLTest.cpp src/tests/gl_tests/GLSLTest.cpp +0 -1

InstancingTest.cpp src/tests/gl_tests/InstancingTest.cpp +0 -3

TextureTest.cpp src/tests/gl_tests/TextureTest.cpp +0 -1

No files found.
--- a/src/tests/gl_tests/GLSLTest.cpp
+++ b/src/tests/gl_tests/GLSLTest.cpp
@@ -497,7 +497,6 @@ TEST_P(GLSLTest, ElseIfRewriting)
    ASSERT_NE(0u, program);

    drawQuad(program, "a_position", 0.5f);
-    swapBuffers();

    EXPECT_PIXEL_EQ(0, 0, 255, 0, 0, 255);
    EXPECT_PIXEL_EQ(getWindowWidth()-1, 0, 0, 255, 0, 255);

--- a/src/tests/gl_tests/InstancingTest.cpp
+++ b/src/tests/gl_tests/InstancingTest.cpp
@@ -160,8 +160,6 @@ class InstancingTest : public ANGLETest
        mDrawArraysInstancedANGLE(GL_TRIANGLES, first, count, instanceCount);

        ASSERT_GL_NO_ERROR();
-
-        swapBuffers();
    }

    virtual void runDrawElementsTest(std::string vs, bool shouldAttribZeroBeInstanced)
@@ -208,7 +206,6 @@ class InstancingTest : public ANGLETest
        // Do the instanced draw
        mDrawElementsInstancedANGLE(GL_TRIANGLES, mIndices.size(), GL_UNSIGNED_SHORT, mIndices.data(), mInstances.size() / 3);

-        swapBuffers();
        ASSERT_GL_NO_ERROR();

        checkQuads();

--- a/src/tests/gl_tests/TextureTest.cpp
+++ b/src/tests/gl_tests/TextureTest.cpp
@@ -219,7 +219,6 @@ class TextureTest : public ANGLETest

        glBindFramebuffer(GL_FRAMEBUFFER, 0);
        drawQuad(m2DProgram, "position", 0.5f);
-        swapBuffers();

        int testImageChannels = std::min(sourceImageChannels, destImageChannels);