Commit 0bba1100 by Jamie Madill

Update OWNERS information.

Also includes some documentation maintenance. Bug: angleproject:4511 Change-Id: I7ecce494909f06387875ff85a10004d0c446bbaf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2124597Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
parent 13c139e7
# See https://chromium.googlesource.com/angle/angle/+/master/doc/ContributingCode.md#selecting-reviewers for per-file owners # See https://chromium.googlesource.com/angle/angle/+/master/doc/ContributingCode.md#selecting-reviewers for more info
cwallez@chromium.org
geofflang@chromium.org geofflang@chromium.org
geofflang@google.com geofflang@google.com
jmadill@chromium.org jmadill@chromium.org
jmadill@google.com
jonahr@google.com
syoussefi@chromium.org syoussefi@chromium.org
syoussefi@google.com
ynovikov@chromium.org ynovikov@chromium.org
ynovikov@google.com
per-file AUTHORS=*
per-file CONTRIBUTORS=*
per-file DEPS=*
per-file WATCHLISTS=*
# COMPONENT: Internals>GPU>ANGLE # COMPONENT: Internals>GPU>ANGLE
# TEAM: angleproject@googlegroups.com # TEAM: angleproject@googlegroups.com
...@@ -4,8 +4,7 @@ ...@@ -4,8 +4,7 @@
* Whether you're writing a new feature or fixing an existing bug, it pays to get a second opinion * Whether you're writing a new feature or fixing an existing bug, it pays to get a second opinion
before you get too far. If it's a new feature idea, post to the discussion group before you get too far. If it's a new feature idea, post to the discussion group
([angleproject][ANGLE-website]) and propose it or talk with the ANGLE team on IRC in the ([angleproject][ANGLE-website]).
`#ANGLEproject` channel on FreeNode.
* Not all bugs in our [bug system][anglebug.com] are assigned, but if the one you're interested in * Not all bugs in our [bug system][anglebug.com] are assigned, but if the one you're interested in
fixing is, send a note to the person it's assigned to and ask if they would like a patch. fixing is, send a note to the person it's assigned to and ask if they would like a patch.
* Behavior changes and anything nontrivial (i.e. anything other than simple cleanups and style * Behavior changes and anything nontrivial (i.e. anything other than simple cleanups and style
...@@ -22,28 +21,32 @@ ...@@ -22,28 +21,32 @@
### Code ### Code
1. Must conform to the [ANGLE style][ANGLE-style] guidelines. 1. Must conform to the [ANGLE style][ANGLE-style] guidelines.
2. Must be tested. (see the 'Testing' section below) 2. Must be tested. (see the [Testing][Testing] section below)
3. Should be a reasonable size to review. Giant patches are unlikely to get reviewed quickly. 3. Should be a reasonable size to review. Giant patches are unlikely to get reviewed quickly.
[ANGLE-style]: CodingStandard.md [ANGLE-style]: CodingStandard.md
[Testing]: #Testing
### Build maintenance ### Build maintenance
1. If you added or removed source files: 1. If you added or removed source files:
* You _must_ update the build files with your changes. See `src/libGLESv2.gni` and * You _must_ update the build files with your changes. See [`src/libGLESv2.gni`][libGLESv2.gni]
`src/compiler.gni`. and [`src/compiler.gni`][compiler.gni].
2. ANGLE's BUILD.gn script is used by [Chromium's gn build][gn-build-config]. If you change build 2. ANGLE's BUILD.gn script is used by [Chromium's gn build][gn-build-config]. If you change build
files other than to add or remove source files be aware you could break the Chromium build. files other than to add or remove source files be aware you could break the Chromium build.
ANGLE's commit queue (CQ) will detect such breakage. Ask a project member for help with Chromium ANGLE's commit queue (CQ) will detect such breakage. Ask a project member for help with Chromium
issues if you don't have a Chromium checkout. issues if you don't have a Chromium checkout.
3. Some generated code is baked into the repository. If you modify the source of these files, such 3. Some generated code is baked into the repository. If you modify the source of these files, such
as the translator's `glslang.l`, or one of the internal shaders in the Vulkan backend, you will as the translator's [`glslang.l`][glslang.l], or one of the internal shaders in the Vulkan
need to run `scripts/run_code_generation.py` and include the autogenerated files in your change. backend, you will need to run [`scripts/run_code_generation.py`][run_code_generation.py] and
include the autogenerated files in your change.
`git cl upload` should warn you if you are missing this step. `git cl upload` should warn you if you are missing this step.
* Note that updating the translator's lexer and parser (using `flex` and `bison`) is only
supported on Linux and Windows.
[gn-build-config]: https://www.chromium.org/developers/gn-build-configuration [gn-build-config]: https://www.chromium.org/developers/gn-build-configuration
[compiler.gni]: https://chromium.googlesource.com/angle/angle/+/refs/heads/master/src/compiler.gni
[libGLESv2.gni]: https://chromium.googlesource.com/angle/angle/+/refs/heads/master/src/libGLESv2.gni
[glslang.l]: https://chromium.googlesource.com/angle/angle/+/refs/heads/master/src/compiler/translator/glslang.l
[run_code_generation.py]: https://chromium.googlesource.com/angle/angle/+/refs/heads/master/scripts/run_code_generation.py
### Testing ### Testing
...@@ -179,14 +182,23 @@ ...@@ -179,14 +182,23 @@
### Selecting reviewers ### Selecting reviewers
When your CL is ready to review, add any of the following reviewers. They will be able to route your When your CL is ready to review, you can use the "Find Owners" button in
CL to additional reviewers as neccessary and answer any questions you may have about the process. All Gerrit to select appropriate code reviewers. They will be able to route your
non-trival CLs should be reviewed by two reviewers. CL to additional reviewers as neccessary and answer any questions you may have
about the process.
* `geofflang at chromium dot org` ### Rules for submission
* `jmadill at chromium dot org`
* `syoussefi at chromium dot org` * At least one **Owner** must give approval.
* `ynovikov at chromium dot org` * The owner must be from the **most specific** directory.
* At least two **Committers** must give approval for non-trival CLs.
For trivial CLs, a single Owner approval is sufficient.
* Only **Committers** may submit CLs. If you aren't a committer please ask for help submitting.
* Committers may submit high-priority small CLs immediately using **TBR**.
See [the Chromium docs][TBR] for more info.
* There are exceptions to these rules. Use your best judgement.
[TBR]: https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#tbr-to-be-reviewed
### Committer status ### Committer status
...@@ -194,7 +206,13 @@ Similar to [Chromium's committer status][Committer-status], long-term contributo ...@@ -194,7 +206,13 @@ Similar to [Chromium's committer status][Committer-status], long-term contributo
project may request to join the `angle-committers` group. This allows you to give `+2` on code project may request to join the `angle-committers` group. This allows you to give `+2` on code
reviews and land patches without assistance. After about 6 months of regular contributions, you may reviews and land patches without assistance. After about 6 months of regular contributions, you may
request committer status from a core ANGLE team member via email or code review. Chromium request committer status from a core ANGLE team member via email or code review. Chromium
committers may ask at any time. committers and Googlers may ask at any time.
### OWNERS files and becoming an Owner
See these Chromium docs for some good guidelines: [link][Owners].
### More info
See also: See also:
...@@ -207,3 +225,4 @@ See also: ...@@ -207,3 +225,4 @@ See also:
[Contributing-code]: http://www.chromium.org/developers/contributing-code/ [Contributing-code]: http://www.chromium.org/developers/contributing-code/
[depot-tools-tutorial]: http://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/depot_tools_tutorial.html [depot-tools-tutorial]: http://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/depot_tools_tutorial.html
[Perftest-README]: ../src/tests/perf_tests/README.md [Perftest-README]: ../src/tests/perf_tests/README.md
[Owners]: https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#expectations-of-owners
per-file *capture*=cnorthrop@google.com
per-file *Capture*=cnorthrop@google.com
geofflang@chromium.org
jmadill@chromium.org
geofflang@chromium.org
jonahr@google.com
jmadill@chromium.org
syoussefi@chromium.org
# All committers are de-facto owners of the tests.
per-file *=*
cnorthrop@google.com
jmadill@chromium.org
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment