Enable some more MSVS compiler warnings.

Also add comments explaining why the one that are still around are still around. Change-Id: Id8ce1fa3fe2a3bc97a179018737cc8d027b1068a Reviewed-on: https://chromium-review.googlesource.com/250878Reviewed-by: Jamie Madill <jmadill@chromium.org> Tested-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org>

Enable some more MSVS compiler warnings.
0d300ca7 · Nico Weber · Jamie Madill · c415283b · 0d300ca7
Commit 0d300ca7 authored Feb 18, 2015 by Nico Weber Committed by Jamie Madill Feb 20, 2015
Hide whitespace changes
Inline Side-by-side

Showing with 13 additions and 1 deletion

common_defines.gypi build/common_defines.gypi +13 -1

No files found.
--- a/build/common_defines.gypi
+++ b/build/common_defines.gypi
@@ -11,7 +11,19 @@
        'angle_build_winrt%': '0',
        'angle_build_winphone%': '0',
    },
-    'msvs_disabled_warnings': [ 4075, 4100, 4127, 4239, 4244, 4245, 4251, 4264, 4267, 4447, 4702, 4718 ],
+    'msvs_disabled_warnings':
+    [
+        4100, # Unreferenced formal parameter. Not interesting.
+        4127, # conditional expression is constant. Too noisy to be useful.
+
+        # Conversion warnings.  These fire all over the place in ANGLE.
+        4244, # Conversion from 'type1' to 'type2', possible loss of data
+        4245, # Conversion from 'type1' to 'type2', signed/unsigned mismatch
+        4267, # Conversion from 'size_t' to 'type', possible loss of data
+
+        4702, # Unreachable code. Useful, but fires on system header xtree.
+        4718, # Recursive call has no side effects. Fires on xtree too.
+    ],
    'msvs_system_include_dirs':
    [
        '<(windows_sdk_path)/Include/shared',