Skip to content

A
angle
Commit 0de5b648 by Nico Weber Committed by Commit Bot
Options

Remove explicit -Wextra-semi, -Winconsistent-missing-override flags.

They're enabled via the chromium_code config already these days. No intended behavior change. Bug: chromium:926235,chromium:428099 Change-Id: I6927d6e3ec85f40454da61969d7a22dfabef1bde Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1564781Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org>
parent e6f4515a
Showing with 0 additions and 9 deletions
BUILD.gn
...@@ -125,19 +125,10 @@ config("extra_warnings") { ...@@ -125,19 +125,10 @@ config("extra_warnings") {
] ]
} }
if (is_clang) { if (is_clang) {
if (!is_fuchsia) {
cflags += [
# Remove when crbug.com/926235 is resolved.
"-Wextra-semi",
]
}
cflags += [ cflags += [
# Enable after anglebug.com/3128 is fixed. # Enable after anglebug.com/3128 is fixed.
# "-Wextra-semi-stmt", # "-Wextra-semi-stmt",
# Remove when crbug.com/428099 is resolved.
"-Winconsistent-missing-override",
"-Wnon-virtual-dtor", "-Wnon-virtual-dtor",
"-Wunneeded-internal-declaration", "-Wunneeded-internal-declaration",
] ]
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment