Commit 0ef5c746 by Corentin Wallez

Revert "gpu_test_expectations: Fix a -Wheader-hygiene"

This patch causes a compile failure, probably because some symbols had been declared in the root namespace and should have been moved to base. (but weren't compiled under Linux) BUG= This reverts commit f41e04db. Change-Id: Ia2292bf9dcbf429f47c8c8632356574a91ff0a1d Reviewed-on: https://chromium-review.googlesource.com/295110Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org> Tested-by: 's avatarCorentin Wallez <cwallez@chromium.org>
parent 1c207ae9
...@@ -5,7 +5,7 @@ will allow us to merge Chromium changes easily in our ```gpu_test_expectations`` ...@@ -5,7 +5,7 @@ will allow us to merge Chromium changes easily in our ```gpu_test_expectations``
In order to make a change to this directory, do the following: In order to make a change to this directory, do the following:
* copy the directory somewhere like in ```gpu_test_expectations_reverted``` * copy the directory somewhere like in ```gpu_test_expectations_reverted```
* in ```gpu_test_expectations_reverted``` run ```patch -p 1 -R < angle-mods.patch``` * in ```gpu_test_expectations_reverted``` run ```patch -p 1 -R angle-mods.patch```
* do your changes in ```gpu_test_expectations``` * do your changes in ```gpu_test_expectations```
* delete angle-mods.path in both directories * delete angle-mods.path in both directories
* run ```diff -rupN gpu_test_expectations_reverted gpu_test_expectations > angle-mods.patch``` * run ```diff -rupN gpu_test_expectations_reverted gpu_test_expectations > angle-mods.patch```
......
...@@ -21,27 +21,17 @@ ...@@ -21,27 +21,17 @@
#define DCHECK_NE(A,B) ASSERT((A) != (B)) #define DCHECK_NE(A,B) ASSERT((A) != (B))
#define DCHECK(X) ASSERT(X) #define DCHECK(X) ASSERT(X)
#define LOG(X) std::cerr #define LOG(X) std::cerr
#define StringPrintf FormatString
#define GPU_EXPORT #define GPU_EXPORT
#define base
typedef int32_t int32; typedef int32_t int32;
typedef uint32_t uint32; typedef uint32_t uint32;
typedef int64_t int64; typedef int64_t int64;
typedef uint64_t uint64; typedef uint64_t uint64;
// Shim Chromium's base by importing functions in the bsae namespace. using namespace angle;
namespace base
{
using angle::HexStringToUInt;
using angle::ReadFileToString;
using angle::SplitString;
using angle::SplitStringAlongWhitespace;
// StringPrintf is called differently in ANGLE but using cannot change
// the name of the imported function. Use a define to change the name.
using ::FormatString;
#define StringPrintf FormatString
}
// TODO(jmadill): other platforms // TODO(jmadill): other platforms
#if defined(_WIN32) || defined(_WIN64) #if defined(_WIN32) || defined(_WIN64)
......
...@@ -6,8 +6,6 @@ ...@@ -6,8 +6,6 @@
#include "common/angleutils.h" #include "common/angleutils.h"
namespace base {
bool StartsWithASCII(const std::string& str, bool StartsWithASCII(const std::string& str,
const std::string& search, const std::string& search,
bool case_sensitive) { bool case_sensitive) {
...@@ -34,8 +32,6 @@ bool LowerCaseEqualsASCII(const std::string& a, const char* b) { ...@@ -34,8 +32,6 @@ bool LowerCaseEqualsASCII(const std::string& a, const char* b) {
return DoLowerCaseEqualsASCII(a.begin(), a.end(), b); return DoLowerCaseEqualsASCII(a.begin(), a.end(), b);
} }
} // namespace base
namespace gpu { namespace gpu {
namespace { namespace {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment