Commit 0f4cefe9 by apatrick@chromium.org

Map D3D calls and HLSL shaders back to GLES2 calls and GLSL ES shaders in PIX.

This makes debugging and profiling using PIX a lot more convenient. The top level of events are the GLES calls with their arguments. Those can be expanded to see the D3D calls that were issued for a particular GLES call. When PIX is attached, the shaders are saved out to temporary files and referenced from the translated HLSL shaders via #line directives. This enabled source level debugging of the original GLSL from PIX for pixel and vertex shaders. The HLSL is also saved to a temporary file so that intrinsic functions like texture2D can be stepped into. It also avoids creating a text file in the current working directory, which has continued to be an issue. I made the dependency on d3d9.dll static again so it can be accessed by GetModuleHandle witihin DllMain. I added an EVENT macro that issues D3DPERF_BeginEvent and D3DPERF_EndEvent around a C++ block. I replaced TRACE with EVENT for all the entry points. I removed the tracing of shader source since the source is visible in PIX. The means by which the filename of the temporary shader file is passed into the shader compiler is a little clunky. I did it that way to avoid changing the function signatures and breaking folks using the translator. I plan to make the compiler respect #pragma optimize so that optimization can be disabled for debugging purposes. For now it just disables shader optimization in debug builds of ANGLE. Review URL: http://codereview.appspot.com/3945043 git-svn-id: https://angleproject.googlecode.com/svn/trunk@541 736b8ea6-26fd-11df-bfd4-992fa37f6226
parent e9874058
...@@ -71,7 +71,9 @@ typedef enum { ...@@ -71,7 +71,9 @@ typedef enum {
SH_VALIDATE_LOOP_INDEXING = 0x0001, SH_VALIDATE_LOOP_INDEXING = 0x0001,
SH_INTERMEDIATE_TREE = 0x0002, SH_INTERMEDIATE_TREE = 0x0002,
SH_OBJECT_CODE = 0x0004, SH_OBJECT_CODE = 0x0004,
SH_ATTRIBUTES_UNIFORMS = 0x0008 SH_ATTRIBUTES_UNIFORMS = 0x0008,
SH_LINE_DIRECTIVES = 0x0010,
SH_SOURCE_PATH = 0x0200,
} ShCompileOptions; } ShCompileOptions;
// //
......
...@@ -5,7 +5,7 @@ ...@@ -5,7 +5,7 @@
{ {
'target_defaults': { 'target_defaults': {
'defines': [ 'defines': [
'TRACE_OUTPUT_FILE="angle-debug.txt"', 'ANGLE_DISABLE_TRACE',
], ],
}, },
'targets': [ 'targets': [
...@@ -183,7 +183,10 @@ ...@@ -183,7 +183,10 @@
'msvs_settings': { 'msvs_settings': {
'VCLinkerTool': { 'VCLinkerTool': {
'AdditionalLibraryDirectories': ['$(DXSDK_DIR)/lib/x86'], 'AdditionalLibraryDirectories': ['$(DXSDK_DIR)/lib/x86'],
'AdditionalDependencies': ['d3dx9.lib'], 'AdditionalDependencies': [
'd3d9.lib',
'd3dx9.lib',
],
} }
}, },
}, },
...@@ -215,6 +218,7 @@ ...@@ -215,6 +218,7 @@
'VCLinkerTool': { 'VCLinkerTool': {
'AdditionalLibraryDirectories': ['$(DXSDK_DIR)/lib/x86'], 'AdditionalLibraryDirectories': ['$(DXSDK_DIR)/lib/x86'],
'AdditionalDependencies': [ 'AdditionalDependencies': [
'd3d9.lib',
'dxguid.lib', 'dxguid.lib',
], ],
} }
......
// //
// Copyright (c) 2002-2010 The ANGLE Project Authors. All rights reserved. // Copyright (c) 2002-2010 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// //
// debug.cpp: Debugging utilities. // debug.cpp: Debugging utilities.
#include "common/debug.h" #include "common/debug.h"
#include <stdio.h> #include <stdio.h>
#include <stdarg.h> #include <stdarg.h>
#include <d3d9.h>
#ifndef TRACE_OUTPUT_FILE #include <windows.h>
#define TRACE_OUTPUT_FILE "debug.txt"
#endif namespace gl
{
static bool trace_on = true;
typedef void (WINAPI *PerfOutputFunction)(D3DCOLOR, LPCWSTR);
namespace gl
{ static void output(bool traceFileDebugOnly, PerfOutputFunction perfFunc, const char *format, va_list vararg)
void trace(const char *format, ...) {
{ #if !defined(ANGLE_DISABLE_PERF)
#if !defined(ANGLE_DISABLE_TRACE) if (perfActive())
if (trace_on) {
{ char message[4096];
if (format) int len = vsprintf_s(message, format, vararg);
{ if (len < 0)
FILE *file = fopen(TRACE_OUTPUT_FILE, "a"); {
return;
if (file) }
{
va_list vararg; // There are no ASCII variants of these D3DPERF functions.
va_start(vararg, format); wchar_t wideMessage[4096];
vfprintf(file, format, vararg); for (int i = 0; i < len; ++i)
va_end(vararg); {
wideMessage[i] = message[i];
fclose(file); }
} wideMessage[len] = 0;
}
} perfFunc(0, wideMessage);
#endif // !defined(ANGLE_DISABLE_TRACE) }
} #endif
}
#if !defined(ANGLE_DISABLE_TRACE)
#if defined(NDEBUG)
if (traceFileDebugOnly)
{
return;
}
#endif
FILE* file = fopen(TRACE_OUTPUT_FILE, "a");
if (file)
{
vfprintf(file, format, vararg);
fclose(file);
}
#endif
}
void trace(bool traceFileDebugOnly, const char *format, ...)
{
va_list vararg;
va_start(vararg, format);
output(traceFileDebugOnly, D3DPERF_SetMarker, format, vararg);
va_end(vararg);
}
bool perfActive()
{
#if defined(ANGLE_DISABLE_PERF)
return false;
#else
return D3DPERF_GetStatus() != 0;
#endif
}
ScopedPerfEventHelper::ScopedPerfEventHelper(const char* format, ...)
{
va_list vararg;
va_start(vararg, format);
output(true, reinterpret_cast<PerfOutputFunction>(D3DPERF_BeginEvent), format, vararg);
va_end(vararg);
}
ScopedPerfEventHelper::~ScopedPerfEventHelper()
{
#if !defined(ANGLE_DISABLE_PERF)
if (perfActive())
{
D3DPERF_EndEvent();
}
#endif
}
}
...@@ -12,49 +12,87 @@ ...@@ -12,49 +12,87 @@
#include <stdio.h> #include <stdio.h>
#include <assert.h> #include <assert.h>
#include "common/angleutils.h"
#if !defined(TRACE_OUTPUT_FILE)
#define TRACE_OUTPUT_FILE "debug.txt"
#endif
namespace gl namespace gl
{ {
// Outputs text to the debugging log // Outputs text to the debugging log
void trace(const char *format, ...); void trace(bool traceFileDebugOnly, const char *format, ...);
// Returns whether D3DPERF is active.
bool perfActive();
// Pairs a D3D begin event with an end event.
class ScopedPerfEventHelper
{
public:
ScopedPerfEventHelper(const char* format, ...);
~ScopedPerfEventHelper();
private:
DISALLOW_COPY_AND_ASSIGN(ScopedPerfEventHelper);
};
} }
// A macro to output a trace of a function call and its arguments to the debugging log // A macro to output a trace of a function call and its arguments to the debugging log
#if !defined(NDEBUG) && !defined(ANGLE_DISABLE_TRACE) #if defined(ANGLE_DISABLE_TRACE) && defined(ANGLE_DISABLE_PERF)
#define TRACE(message, ...) gl::trace("trace: %s"message"\n", __FUNCTION__, __VA_ARGS__) #define TRACE(message, ...) (void(0))
#else
#define TRACE(message, ...) gl::trace(true, "trace: %s(%d): "message"\n", __FUNCTION__, __LINE__, __VA_ARGS__)
#endif
// A macro to output a function call and its arguments to the debugging log, to denote an item in need of fixing.
#if defined(ANGLE_DISABLE_TRACE) && defined(ANGLE_DISABLE_PERF)
#define FIXME(message, ...) (void(0))
#else #else
#define TRACE(...) ((void)0) #define FIXME(message, ...) gl::trace(false, "fixme: %s(%d): "message"\n", __FUNCTION__, __LINE__, __VA_ARGS__)
#endif #endif
// A macro to output a function call and its arguments to the debugging log, to denote an item in need of fixing. Will occur even in release mode. // A macro to output a function call and its arguments to the debugging log, in case of error.
#define FIXME(message, ...) gl::trace("fixme: %s"message"\n", __FUNCTION__, __VA_ARGS__) #if defined(ANGLE_DISABLE_TRACE) && defined(ANGLE_DISABLE_PERF)
#define ERR(message, ...) (void(0))
#else
#define ERR(message, ...) gl::trace(false, "err: %s(%d): "message"\n", __FUNCTION__, __LINE__, __VA_ARGS__)
#endif
// A macro to output a function call and its arguments to the debugging log, in case of error. Will occur even in release mode. // A macro to log a performance event around a scope.
#define ERR(message, ...) gl::trace("err: %s"message"\n", __FUNCTION__, __VA_ARGS__) #if defined(ANGLE_DISABLE_TRACE) && defined(ANGLE_DISABLE_PERF)
#define EVENT(message, ...) (void(0))
#else
#define EVENT(message, ...) gl::ScopedPerfEventHelper scopedPerfEventHelper ## __LINE__("%s\n" message, __FUNCTION__, __VA_ARGS__);
#endif
// A macro asserting a condition and outputting failures to the debug log // A macro asserting a condition and outputting failures to the debug log
#if !defined(NDEBUG)
#define ASSERT(expression) do { \ #define ASSERT(expression) do { \
if(!(expression)) \ if(!(expression)) \
ERR("\t! Assert failed in %s(%d): "#expression"\n", __FUNCTION__, __LINE__); \ ERR("\t! Assert failed in %s(%d): "#expression"\n", __FUNCTION__, __LINE__); \
assert(expression); \ assert(expression); \
} while(0) } while(0)
#else
#define ASSERT(expression) (void(0))
#endif
// A macro to indicate unimplemented functionality // A macro to indicate unimplemented functionality
#ifndef NDEBUG #if !defined(NDEBUG)
#define UNIMPLEMENTED() do { \ #define UNIMPLEMENTED() do { \
FIXME("\t! Unimplemented: %s(%d)\n", __FUNCTION__, __LINE__); \ FIXME("\t! Unimplemented: %s(%d)\n", __FUNCTION__, __LINE__); \
assert(false); \ assert(false); \
} while(0) } while(0)
#else #else
#define UNIMPLEMENTED() FIXME("\t! Unimplemented: %s(%d)\n", __FUNCTION__, __LINE__) #define UNIMPLEMENTED() FIXME("\t! Unimplemented: %s(%d)\n", __FUNCTION__, __LINE__)
#endif #endif
// A macro for code which is not expected to be reached under valid assumptions // A macro for code which is not expected to be reached under valid assumptions
#ifndef NDEBUG #if !defined(NDEBUG)
#define UNREACHABLE() do { \ #define UNREACHABLE() do { \
ERR("\t! Unreachable reached: %s(%d)\n", __FUNCTION__, __LINE__); \ ERR("\t! Unreachable reached: %s(%d)\n", __FUNCTION__, __LINE__); \
assert(false); \ assert(false); \
} while(0) } while(0)
#else #else
#define UNREACHABLE() ERR("\t! Unreachable reached: %s(%d)\n", __FUNCTION__, __LINE__) #define UNREACHABLE() ERR("\t! Unreachable reached: %s(%d)\n", __FUNCTION__, __LINE__)
#endif #endif
......
#define MAJOR_VERSION 0 #define MAJOR_VERSION 0
#define MINOR_VERSION 0 #define MINOR_VERSION 0
#define BUILD_VERSION 0 #define BUILD_VERSION 0
#define BUILD_REVISION 540 #define BUILD_REVISION 541
#define STRINGIFY(x) #x #define STRINGIFY(x) #x
#define MACRO_STRINGIFY(x) STRINGIFY(x) #define MACRO_STRINGIFY(x) STRINGIFY(x)
......
...@@ -17,7 +17,7 @@ bool InitializeSymbolTable( ...@@ -17,7 +17,7 @@ bool InitializeSymbolTable(
{ {
TIntermediate intermediate(infoSink); TIntermediate intermediate(infoSink);
TExtensionBehavior extBehavior; TExtensionBehavior extBehavior;
TParseContext parseContext(symbolTable, extBehavior, intermediate, type, spec, infoSink); TParseContext parseContext(symbolTable, extBehavior, intermediate, type, spec, 0, NULL, infoSink);
GlobalParseContext = &parseContext; GlobalParseContext = &parseContext;
...@@ -115,9 +115,19 @@ bool TCompiler::compile(const char* const shaderStrings[], ...@@ -115,9 +115,19 @@ bool TCompiler::compile(const char* const shaderStrings[],
if (shaderSpec == SH_WEBGL_SPEC) if (shaderSpec == SH_WEBGL_SPEC)
compileOptions |= SH_VALIDATE_LOOP_INDEXING; compileOptions |= SH_VALIDATE_LOOP_INDEXING;
// First string is path of source file if flag is set. The actual source follows.
const char* sourcePath = NULL;
int firstSource = 0;
if (compileOptions & SH_SOURCE_PATH)
{
sourcePath = shaderStrings[0];
++firstSource;
}
TIntermediate intermediate(infoSink); TIntermediate intermediate(infoSink);
TParseContext parseContext(symbolTable, extensionBehavior, intermediate, TParseContext parseContext(symbolTable, extensionBehavior, intermediate,
shaderType, shaderSpec, infoSink); shaderType, shaderSpec, compileOptions,
sourcePath, infoSink);
GlobalParseContext = &parseContext; GlobalParseContext = &parseContext;
// We preserve symbols at the built-in level from compile-to-compile. // We preserve symbols at the built-in level from compile-to-compile.
...@@ -128,7 +138,7 @@ bool TCompiler::compile(const char* const shaderStrings[], ...@@ -128,7 +138,7 @@ bool TCompiler::compile(const char* const shaderStrings[],
// Parse shader. // Parse shader.
bool success = bool success =
(PaParseStrings(numStrings, shaderStrings, NULL, &parseContext) == 0) && (PaParseStrings(numStrings - firstSource, &shaderStrings[firstSource], NULL, &parseContext) == 0) &&
(parseContext.treeRoot != NULL); (parseContext.treeRoot != NULL);
if (success) { if (success) {
TIntermNode* root = parseContext.treeRoot; TIntermNode* root = parseContext.treeRoot;
......
...@@ -1003,6 +1003,7 @@ bool OutputHLSL::visitAggregate(Visit visit, TIntermAggregate *node) ...@@ -1003,6 +1003,7 @@ bool OutputHLSL::visitAggregate(Visit visit, TIntermAggregate *node)
{ {
if (mInsideFunction) if (mInsideFunction)
{ {
outputLineDirective(node->getLine());
out << "{\n"; out << "{\n";
mScopeDepth++; mScopeDepth++;
...@@ -1019,6 +1020,8 @@ bool OutputHLSL::visitAggregate(Visit visit, TIntermAggregate *node) ...@@ -1019,6 +1020,8 @@ bool OutputHLSL::visitAggregate(Visit visit, TIntermAggregate *node)
for (TIntermSequence::iterator sit = node->getSequence().begin(); sit != node->getSequence().end(); sit++) for (TIntermSequence::iterator sit = node->getSequence().begin(); sit != node->getSequence().end(); sit++)
{ {
outputLineDirective((*sit)->getLine());
if (isSingleStatement(*sit)) if (isSingleStatement(*sit))
{ {
mUnfoldSelect->traverse(*sit); mUnfoldSelect->traverse(*sit);
...@@ -1031,6 +1034,7 @@ bool OutputHLSL::visitAggregate(Visit visit, TIntermAggregate *node) ...@@ -1031,6 +1034,7 @@ bool OutputHLSL::visitAggregate(Visit visit, TIntermAggregate *node)
if (mInsideFunction) if (mInsideFunction)
{ {
outputLineDirective(node->getEndLine());
out << "}\n"; out << "}\n";
mScopeDepth--; mScopeDepth--;
...@@ -1171,13 +1175,16 @@ bool OutputHLSL::visitAggregate(Visit visit, TIntermAggregate *node) ...@@ -1171,13 +1175,16 @@ bool OutputHLSL::visitAggregate(Visit visit, TIntermAggregate *node)
sequence.erase(sequence.begin()); sequence.erase(sequence.begin());
out << ")\n" out << ")\n";
"{\n";
outputLineDirective(node->getLine());
out << "{\n";
mInsideFunction = true; mInsideFunction = true;
} }
else if (visit == PostVisit) else if (visit == PostVisit)
{ {
outputLineDirective(node->getEndLine());
out << "}\n"; out << "}\n";
mInsideFunction = false; mInsideFunction = false;
...@@ -1402,23 +1409,30 @@ bool OutputHLSL::visitSelection(Visit visit, TIntermSelection *node) ...@@ -1402,23 +1409,30 @@ bool OutputHLSL::visitSelection(Visit visit, TIntermSelection *node)
node->getCondition()->traverse(this); node->getCondition()->traverse(this);
out << ")\n" out << ")\n";
"{\n";
outputLineDirective(node->getLine());
out << "{\n";
if (node->getTrueBlock()) if (node->getTrueBlock())
{ {
node->getTrueBlock()->traverse(this); node->getTrueBlock()->traverse(this);
} }
outputLineDirective(node->getLine());
out << ";}\n"; out << ";}\n";
if (node->getFalseBlock()) if (node->getFalseBlock())
{ {
out << "else\n" out << "else\n";
"{\n";
outputLineDirective(node->getFalseBlock()->getLine());
out << "{\n";
outputLineDirective(node->getFalseBlock()->getLine());
node->getFalseBlock()->traverse(this); node->getFalseBlock()->traverse(this);
outputLineDirective(node->getFalseBlock()->getLine());
out << ";}\n"; out << ";}\n";
} }
} }
...@@ -1442,8 +1456,10 @@ bool OutputHLSL::visitLoop(Visit visit, TIntermLoop *node) ...@@ -1442,8 +1456,10 @@ bool OutputHLSL::visitLoop(Visit visit, TIntermLoop *node)
if (node->getType() == ELoopDoWhile) if (node->getType() == ELoopDoWhile)
{ {
out << "do\n" out << "do\n";
"{\n";
outputLineDirective(node->getLine());
out << "{\n";
} }
else else
{ {
...@@ -1483,8 +1499,10 @@ bool OutputHLSL::visitLoop(Visit visit, TIntermLoop *node) ...@@ -1483,8 +1499,10 @@ bool OutputHLSL::visitLoop(Visit visit, TIntermLoop *node)
node->getExpression()->traverse(this); node->getExpression()->traverse(this);
} }
out << ")\n" out << ")\n";
"{\n";
outputLineDirective(node->getLine());
out << "{\n";
} }
if (node->getBody()) if (node->getBody())
...@@ -1492,10 +1510,12 @@ bool OutputHLSL::visitLoop(Visit visit, TIntermLoop *node) ...@@ -1492,10 +1510,12 @@ bool OutputHLSL::visitLoop(Visit visit, TIntermLoop *node)
node->getBody()->traverse(this); node->getBody()->traverse(this);
} }
outputLineDirective(node->getLine());
out << "}\n"; out << "}\n";
if (node->getType() == ELoopDoWhile) if (node->getType() == ELoopDoWhile)
{ {
outputLineDirective(node->getCondition()->getLine());
out << "while(\n"; out << "while(\n";
node->getCondition()->traverse(this); node->getCondition()->traverse(this);
...@@ -1531,7 +1551,10 @@ bool OutputHLSL::visitBranch(Visit visit, TIntermBranch *node) ...@@ -1531,7 +1551,10 @@ bool OutputHLSL::visitBranch(Visit visit, TIntermBranch *node)
} }
else if (visit == PostVisit) else if (visit == PostVisit)
{ {
out << ";\n"; if (node->getExpression())
{
out << ";\n";
}
} }
break; break;
default: UNREACHABLE(); default: UNREACHABLE();
...@@ -1711,14 +1734,17 @@ bool OutputHLSL::handleExcessiveLoop(TIntermLoop *node) ...@@ -1711,14 +1734,17 @@ bool OutputHLSL::handleExcessiveLoop(TIntermLoop *node)
index->traverse(this); index->traverse(this);
out << " += "; out << " += ";
out << increment; out << increment;
out << ")\n" out << ")\n";
"{\n";
outputLineDirective(node->getLine());
out << "{\n";
if (node->getBody()) if (node->getBody())
{ {
node->getBody()->traverse(this); node->getBody()->traverse(this);
} }
outputLineDirective(node->getLine());
out << "}\n"; out << "}\n";
initial += 255 * increment; initial += 255 * increment;
...@@ -1751,6 +1777,21 @@ void OutputHLSL::outputTriplet(Visit visit, const TString &preString, const TStr ...@@ -1751,6 +1777,21 @@ void OutputHLSL::outputTriplet(Visit visit, const TString &preString, const TStr
} }
} }
void OutputHLSL::outputLineDirective(int line)
{
if ((mContext.compileOptions & SH_LINE_DIRECTIVES) && (line > 0))
{
mBody << "#line " << line;
if (mContext.sourcePath)
{
mBody << " \"" << mContext.sourcePath << "\"";
}
mBody << "\n";
}
}
TString OutputHLSL::argumentString(const TIntermSymbol *symbol) TString OutputHLSL::argumentString(const TIntermSymbol *symbol)
{ {
TQualifier qualifier = symbol->getQualifier(); TQualifier qualifier = symbol->getQualifier();
......
...@@ -49,6 +49,7 @@ class OutputHLSL : public TIntermTraverser ...@@ -49,6 +49,7 @@ class OutputHLSL : public TIntermTraverser
bool isSingleStatement(TIntermNode *node); bool isSingleStatement(TIntermNode *node);
bool handleExcessiveLoop(TIntermLoop *node); bool handleExcessiveLoop(TIntermLoop *node);
void outputTriplet(Visit visit, const TString &preString, const TString &inString, const TString &postString); void outputTriplet(Visit visit, const TString &preString, const TString &inString, const TString &postString);
void outputLineDirective(int line);
TString argumentString(const TIntermSymbol *symbol); TString argumentString(const TIntermSymbol *symbol);
int vectorSize(const TType &type) const; int vectorSize(const TType &type) const;
......
...@@ -30,8 +30,8 @@ struct TPragma { ...@@ -30,8 +30,8 @@ struct TPragma {
// they can be passed to the parser without needing a global. // they can be passed to the parser without needing a global.
// //
struct TParseContext { struct TParseContext {
TParseContext(TSymbolTable& symt, const TExtensionBehavior& ext, TIntermediate& interm, ShShaderType type, ShShaderSpec spec, TInfoSink& is) : TParseContext(TSymbolTable& symt, const TExtensionBehavior& ext, TIntermediate& interm, ShShaderType type, ShShaderSpec spec, int options, const char* sourcePath, TInfoSink& is) :
intermediate(interm), symbolTable(symt), extensionBehavior(ext), infoSink(is), shaderType(type), shaderSpec(spec), treeRoot(0), intermediate(interm), symbolTable(symt), extensionBehavior(ext), infoSink(is), shaderType(type), shaderSpec(spec), compileOptions(options), sourcePath(sourcePath), treeRoot(0),
recoveredFromError(false), numErrors(0), lexAfterType(false), loopNestingLevel(0), recoveredFromError(false), numErrors(0), lexAfterType(false), loopNestingLevel(0),
inTypeParen(false), scanner(NULL), contextPragma(true, false) { } inTypeParen(false), scanner(NULL), contextPragma(true, false) { }
TIntermediate& intermediate; // to hold and build a parse tree TIntermediate& intermediate; // to hold and build a parse tree
...@@ -40,6 +40,8 @@ struct TParseContext { ...@@ -40,6 +40,8 @@ struct TParseContext {
TInfoSink& infoSink; TInfoSink& infoSink;
ShShaderType shaderType; // vertex or fragment language (future: pack or unpack) ShShaderType shaderType; // vertex or fragment language (future: pack or unpack)
ShShaderSpec shaderSpec; // The language specification compiler conforms to - GLES2 or WebGL. ShShaderSpec shaderSpec; // The language specification compiler conforms to - GLES2 or WebGL.
int compileOptions;
const char* sourcePath; // Path of source file or NULL.
TIntermNode* treeRoot; // root of parse tree being created TIntermNode* treeRoot; // root of parse tree being created
bool recoveredFromError; // true if a parse error has occurred, but we continue to parse bool recoveredFromError; // true if a parse error has occurred, but we continue to parse
int numErrors; int numErrors;
......
...@@ -1770,8 +1770,10 @@ simple_statement ...@@ -1770,8 +1770,10 @@ simple_statement
compound_statement compound_statement
: LEFT_BRACE RIGHT_BRACE { $$ = 0; } : LEFT_BRACE RIGHT_BRACE { $$ = 0; }
| LEFT_BRACE { context->symbolTable.push(); } statement_list { context->symbolTable.pop(); } RIGHT_BRACE { | LEFT_BRACE { context->symbolTable.push(); } statement_list { context->symbolTable.pop(); } RIGHT_BRACE {
if ($3 != 0) if ($3 != 0) {
$3->setOp(EOpSequence); $3->setOp(EOpSequence);
$3->setEndLine($5.line);
}
$$ = $3; $$ = $3;
} }
; ;
...@@ -1787,8 +1789,10 @@ compound_statement_no_new_scope ...@@ -1787,8 +1789,10 @@ compound_statement_no_new_scope
$$ = 0; $$ = 0;
} }
| LEFT_BRACE statement_list RIGHT_BRACE { | LEFT_BRACE statement_list RIGHT_BRACE {
if ($2) if ($2) {
$2->setOp(EOpSequence); $2->setOp(EOpSequence);
$2->setEndLine($3.line);
}
$$ = $2; $$ = $2;
} }
; ;
...@@ -2061,6 +2065,9 @@ function_definition ...@@ -2061,6 +2065,9 @@ function_definition
$$->getAsAggregate()->setOptimize(context->contextPragma.optimize); $$->getAsAggregate()->setOptimize(context->contextPragma.optimize);
$$->getAsAggregate()->setDebug(context->contextPragma.debug); $$->getAsAggregate()->setDebug(context->contextPragma.debug);
$$->getAsAggregate()->addToPragmaTable(context->contextPragma.pragmaTable); $$->getAsAggregate()->addToPragmaTable(context->contextPragma.pragmaTable);
if ($3 && $3->getAsAggregate())
$$->getAsAggregate()->setEndLine($3->getAsAggregate()->getEndLine());
} }
; ;
......
...@@ -744,11 +744,11 @@ static const yytype_uint16 yyrline[] = ...@@ -744,11 +744,11 @@ static const yytype_uint16 yyrline[] =
1553, 1558, 1563, 1568, 1573, 1578, 1583, 1588, 1593, 1598, 1553, 1558, 1563, 1568, 1573, 1578, 1583, 1588, 1593, 1598,
1604, 1610, 1616, 1621, 1626, 1631, 1644, 1657, 1665, 1668, 1604, 1610, 1616, 1621, 1626, 1631, 1644, 1657, 1665, 1668,
1683, 1714, 1718, 1724, 1732, 1748, 1752, 1756, 1757, 1763, 1683, 1714, 1718, 1724, 1732, 1748, 1752, 1756, 1757, 1763,
1764, 1765, 1766, 1767, 1771, 1772, 1772, 1772, 1780, 1781, 1764, 1765, 1766, 1767, 1771, 1772, 1772, 1772, 1782, 1783,
1786, 1789, 1797, 1800, 1806, 1807, 1811, 1819, 1823, 1833, 1788, 1791, 1801, 1804, 1810, 1811, 1815, 1823, 1827, 1837,
1838, 1855, 1855, 1860, 1860, 1867, 1867, 1875, 1878, 1884, 1842, 1859, 1859, 1864, 1864, 1871, 1871, 1879, 1882, 1888,
1887, 1893, 1897, 1904, 1911, 1918, 1925, 1936, 1945, 1949, 1891, 1897, 1901, 1908, 1915, 1922, 1929, 1940, 1949, 1953,
1956, 1959, 1965, 1965 1960, 1963, 1969, 1969
}; };
#endif #endif
...@@ -4094,8 +4094,10 @@ yyreduce: ...@@ -4094,8 +4094,10 @@ yyreduce:
case 157: case 157:
{ {
if ((yyvsp[(3) - (5)].interm.intermAggregate) != 0) if ((yyvsp[(3) - (5)].interm.intermAggregate) != 0) {
(yyvsp[(3) - (5)].interm.intermAggregate)->setOp(EOpSequence); (yyvsp[(3) - (5)].interm.intermAggregate)->setOp(EOpSequence);
(yyvsp[(3) - (5)].interm.intermAggregate)->setEndLine((yyvsp[(5) - (5)].lex).line);
}
(yyval.interm.intermAggregate) = (yyvsp[(3) - (5)].interm.intermAggregate); (yyval.interm.intermAggregate) = (yyvsp[(3) - (5)].interm.intermAggregate);
;} ;}
break; break;
...@@ -4120,8 +4122,10 @@ yyreduce: ...@@ -4120,8 +4122,10 @@ yyreduce:
case 161: case 161:
{ {
if ((yyvsp[(2) - (3)].interm.intermAggregate)) if ((yyvsp[(2) - (3)].interm.intermAggregate)) {
(yyvsp[(2) - (3)].interm.intermAggregate)->setOp(EOpSequence); (yyvsp[(2) - (3)].interm.intermAggregate)->setOp(EOpSequence);
(yyvsp[(2) - (3)].interm.intermAggregate)->setEndLine((yyvsp[(3) - (3)].lex).line);
}
(yyval.interm.intermNode) = (yyvsp[(2) - (3)].interm.intermAggregate); (yyval.interm.intermNode) = (yyvsp[(2) - (3)].interm.intermAggregate);
;} ;}
break; break;
...@@ -4481,6 +4485,9 @@ yyreduce: ...@@ -4481,6 +4485,9 @@ yyreduce:
(yyval.interm.intermNode)->getAsAggregate()->setOptimize(context->contextPragma.optimize); (yyval.interm.intermNode)->getAsAggregate()->setOptimize(context->contextPragma.optimize);
(yyval.interm.intermNode)->getAsAggregate()->setDebug(context->contextPragma.debug); (yyval.interm.intermNode)->getAsAggregate()->setDebug(context->contextPragma.debug);
(yyval.interm.intermNode)->getAsAggregate()->addToPragmaTable(context->contextPragma.pragmaTable); (yyval.interm.intermNode)->getAsAggregate()->addToPragmaTable(context->contextPragma.pragmaTable);
if ((yyvsp[(3) - (3)].interm.intermNode) && (yyvsp[(3) - (3)].interm.intermNode)->getAsAggregate())
(yyval.interm.intermNode)->getAsAggregate()->setEndLine((yyvsp[(3) - (3)].interm.intermNode)->getAsAggregate()->getEndLine());
;} ;}
break; break;
......
...@@ -420,7 +420,7 @@ typedef TMap<TString, TString> TPragmaTable; ...@@ -420,7 +420,7 @@ typedef TMap<TString, TString> TPragmaTable;
// //
class TIntermAggregate : public TIntermOperator { class TIntermAggregate : public TIntermOperator {
public: public:
TIntermAggregate() : TIntermOperator(EOpNull), userDefined(false), pragmaTable(0) { } TIntermAggregate() : TIntermOperator(EOpNull), userDefined(false), pragmaTable(0), endLine(0) { }
TIntermAggregate(TOperator o) : TIntermOperator(o), pragmaTable(0) { } TIntermAggregate(TOperator o) : TIntermOperator(o), pragmaTable(0) { }
~TIntermAggregate() { delete pragmaTable; } ~TIntermAggregate() { delete pragmaTable; }
...@@ -441,6 +441,8 @@ public: ...@@ -441,6 +441,8 @@ public:
bool getDebug() { return debug; } bool getDebug() { return debug; }
void addToPragmaTable(const TPragmaTable& pTable); void addToPragmaTable(const TPragmaTable& pTable);
const TPragmaTable& getPragmaTable() const { return *pragmaTable; } const TPragmaTable& getPragmaTable() const { return *pragmaTable; }
void setEndLine(TSourceLoc line) { endLine = line; }
TSourceLoc getEndLine() const { return endLine; }
protected: protected:
TIntermAggregate(const TIntermAggregate&); // disallow copy constructor TIntermAggregate(const TIntermAggregate&); // disallow copy constructor
...@@ -452,6 +454,7 @@ protected: ...@@ -452,6 +454,7 @@ protected:
bool optimize; bool optimize;
bool debug; bool debug;
TPragmaTable *pragmaTable; TPragmaTable *pragmaTable;
TSourceLoc endLine;
}; };
// //
......
...@@ -55,22 +55,13 @@ bool Display::initialize() ...@@ -55,22 +55,13 @@ bool Display::initialize()
return true; return true;
} }
mD3d9Module = LoadLibrary(TEXT("d3d9.dll")); mD3d9Module = GetModuleHandle(TEXT("d3d9.dll"));
if (mD3d9Module == NULL) if (mD3d9Module == NULL)
{ {
terminate(); terminate();
return false; return false;
} }
typedef IDirect3D9* (WINAPI *Direct3DCreate9Func)(UINT);
Direct3DCreate9Func Direct3DCreate9Ptr = reinterpret_cast<Direct3DCreate9Func>(GetProcAddress(mD3d9Module, "Direct3DCreate9"));
if (Direct3DCreate9Ptr == NULL)
{
terminate();
return false;
}
typedef HRESULT (WINAPI *Direct3DCreate9ExFunc)(UINT, IDirect3D9Ex**); typedef HRESULT (WINAPI *Direct3DCreate9ExFunc)(UINT, IDirect3D9Ex**);
Direct3DCreate9ExFunc Direct3DCreate9ExPtr = reinterpret_cast<Direct3DCreate9ExFunc>(GetProcAddress(mD3d9Module, "Direct3DCreate9Ex")); Direct3DCreate9ExFunc Direct3DCreate9ExPtr = reinterpret_cast<Direct3DCreate9ExFunc>(GetProcAddress(mD3d9Module, "Direct3DCreate9Ex"));
...@@ -85,7 +76,7 @@ bool Display::initialize() ...@@ -85,7 +76,7 @@ bool Display::initialize()
} }
else else
{ {
mD3d9 = Direct3DCreate9Ptr(D3D_SDK_VERSION); mD3d9 = Direct3DCreate9(D3D_SDK_VERSION);
} }
if (mD3d9) if (mD3d9)
...@@ -267,7 +258,6 @@ void Display::terminate() ...@@ -267,7 +258,6 @@ void Display::terminate()
if (mD3d9Module) if (mD3d9Module)
{ {
FreeLibrary(mD3d9Module);
mD3d9Module = NULL; mD3d9Module = NULL;
} }
} }
......
...@@ -62,7 +62,7 @@ ...@@ -62,7 +62,7 @@
/> />
<Tool <Tool
Name="VCLinkerTool" Name="VCLinkerTool"
AdditionalDependencies="dxguid.lib" AdditionalDependencies="d3d9.lib dxguid.lib"
LinkIncremental="2" LinkIncremental="2"
ModuleDefinitionFile="libEGL.def" ModuleDefinitionFile="libEGL.def"
GenerateDebugInformation="true" GenerateDebugInformation="true"
...@@ -140,7 +140,7 @@ ...@@ -140,7 +140,7 @@
/> />
<Tool <Tool
Name="VCLinkerTool" Name="VCLinkerTool"
AdditionalDependencies="dxguid.lib" AdditionalDependencies="d3d9.lib dxguid.lib"
LinkIncremental="1" LinkIncremental="1"
ModuleDefinitionFile="libEGL.def" ModuleDefinitionFile="libEGL.def"
GenerateDebugInformation="true" GenerateDebugInformation="true"
......
...@@ -18,16 +18,16 @@ BOOL WINAPI DllMain(HINSTANCE instance, DWORD reason, LPVOID reserved) ...@@ -18,16 +18,16 @@ BOOL WINAPI DllMain(HINSTANCE instance, DWORD reason, LPVOID reserved)
{ {
case DLL_PROCESS_ATTACH: case DLL_PROCESS_ATTACH:
{ {
#ifndef NDEBUG #if !defined(ANGLE_DISABLE_TRACE)
FILE *debug = fopen("debug.txt", "rt"); FILE *debug = fopen(TRACE_OUTPUT_FILE, "rt");
if (debug) if (debug)
{ {
fclose(debug); fclose(debug);
debug = fopen("debug.txt", "wt"); // Erase debug = fopen(TRACE_OUTPUT_FILE, "wt"); // Erase
fclose(debug); fclose(debug);
} }
#endif #endif
currentTLS = TlsAlloc(); currentTLS = TlsAlloc();
......
...@@ -971,7 +971,24 @@ ID3DXBuffer *Program::compileToBinary(const char *hlsl, const char *profile, ID3 ...@@ -971,7 +971,24 @@ ID3DXBuffer *Program::compileToBinary(const char *hlsl, const char *profile, ID3
ID3DXBuffer *binary = NULL; ID3DXBuffer *binary = NULL;
ID3DXBuffer *errorMessage = NULL; ID3DXBuffer *errorMessage = NULL;
HRESULT result = D3DXCompileShader(hlsl, (UINT)strlen(hlsl), NULL, NULL, "main", profile, 0, &binary, &errorMessage, constantTable); DWORD result;
if (perfActive())
{
DWORD flags = D3DXSHADER_DEBUG;
#ifndef NDEBUG
flags |= D3DXSHADER_SKIPOPTIMIZATION;
#endif
std::string sourcePath = getTempPath();
std::string sourceText = std::string("#line 2 \"") + sourcePath + std::string("\"\n\n") + std::string(hlsl);
writeFile(sourcePath.c_str(), sourceText.c_str(), sourceText.size());
result = D3DXCompileShader(sourceText.c_str(), sourceText.size(), NULL, NULL, "main", profile, flags, &binary, &errorMessage, constantTable);
}
else
{
result = D3DXCompileShader(hlsl, (UINT)strlen(hlsl), NULL, NULL, "main", profile, 0, &binary, &errorMessage, constantTable);
}
if (SUCCEEDED(result)) if (SUCCEEDED(result))
{ {
...@@ -1461,9 +1478,6 @@ bool Program::linkVaryings() ...@@ -1461,9 +1478,6 @@ bool Program::linkVaryings()
" return output;\n" " return output;\n"
"}\n"; "}\n";
TRACE("\n%s", mPixelHLSL.c_str());
TRACE("\n%s", mVertexHLSL.c_str());
return true; return true;
} }
......
...@@ -278,12 +278,33 @@ void Shader::compileToHLSL(void *compiler) ...@@ -278,12 +278,33 @@ void Shader::compileToHLSL(void *compiler)
return; return;
} }
TRACE("\n%s", mSource);
delete[] mInfoLog; delete[] mInfoLog;
mInfoLog = NULL; mInfoLog = NULL;
int result = ShCompile(compiler, &mSource, 1, SH_OBJECT_CODE); int compileOptions = SH_OBJECT_CODE;
std::string sourcePath;
if (perfActive())
{
sourcePath = getTempPath();
writeFile(sourcePath.c_str(), mSource, strlen(mSource));
compileOptions |= SH_LINE_DIRECTIVES;
}
int result;
if (sourcePath.empty())
{
result = ShCompile(compiler, &mSource, 1, compileOptions);
}
else
{
const char* sourceStrings[2] =
{
sourcePath.c_str(),
mSource
};
result = ShCompile(compiler, sourceStrings, 2, compileOptions | SH_SOURCE_PATH);
}
if (result) if (result)
{ {
...@@ -291,8 +312,6 @@ void Shader::compileToHLSL(void *compiler) ...@@ -291,8 +312,6 @@ void Shader::compileToHLSL(void *compiler)
ShGetInfo(compiler, SH_OBJECT_CODE_LENGTH, &objCodeLen); ShGetInfo(compiler, SH_OBJECT_CODE_LENGTH, &objCodeLen);
mHlsl = new char[objCodeLen]; mHlsl = new char[objCodeLen];
ShGetObjectCode(compiler, mHlsl); ShGetObjectCode(compiler, mHlsl);
TRACE("\n%s", mHlsl);
} }
else else
{ {
......
...@@ -62,7 +62,7 @@ ...@@ -62,7 +62,7 @@
/> />
<Tool <Tool
Name="VCLinkerTool" Name="VCLinkerTool"
AdditionalDependencies="D3dx9.lib" AdditionalDependencies="d3d9.lib D3dx9.lib"
LinkIncremental="2" LinkIncremental="2"
ModuleDefinitionFile="libGLESv2.def" ModuleDefinitionFile="libGLESv2.def"
GenerateDebugInformation="true" GenerateDebugInformation="true"
...@@ -140,7 +140,7 @@ ...@@ -140,7 +140,7 @@
/> />
<Tool <Tool
Name="VCLinkerTool" Name="VCLinkerTool"
AdditionalDependencies="D3dx9.lib" AdditionalDependencies="d3d9.lib D3dx9.lib"
LinkIncremental="1" LinkIncremental="1"
IgnoreAllDefaultLibraries="false" IgnoreAllDefaultLibraries="false"
ModuleDefinitionFile="libGLESv2.def" ModuleDefinitionFile="libGLESv2.def"
......
...@@ -119,23 +119,23 @@ void error(GLenum errorCode) ...@@ -119,23 +119,23 @@ void error(GLenum errorCode)
{ {
case GL_INVALID_ENUM: case GL_INVALID_ENUM:
context->recordInvalidEnum(); context->recordInvalidEnum();
gl::trace("\t! Error generated: invalid enum\n"); TRACE("\t! Error generated: invalid enum\n");
break; break;
case GL_INVALID_VALUE: case GL_INVALID_VALUE:
context->recordInvalidValue(); context->recordInvalidValue();
gl::trace("\t! Error generated: invalid value\n"); TRACE("\t! Error generated: invalid value\n");
break; break;
case GL_INVALID_OPERATION: case GL_INVALID_OPERATION:
context->recordInvalidOperation(); context->recordInvalidOperation();
gl::trace("\t! Error generated: invalid operation\n"); TRACE("\t! Error generated: invalid operation\n");
break; break;
case GL_OUT_OF_MEMORY: case GL_OUT_OF_MEMORY:
context->recordOutOfMemory(); context->recordOutOfMemory();
gl::trace("\t! Error generated: out of memory\n"); TRACE("\t! Error generated: out of memory\n");
break; break;
case GL_INVALID_FRAMEBUFFER_OPERATION: case GL_INVALID_FRAMEBUFFER_OPERATION:
context->recordInvalidFramebufferOperation(); context->recordInvalidFramebufferOperation();
gl::trace("\t! Error generated: invalid framebuffer operation\n"); TRACE("\t! Error generated: invalid framebuffer operation\n");
break; break;
default: UNREACHABLE(); default: UNREACHABLE();
} }
......
...@@ -9,6 +9,8 @@ ...@@ -9,6 +9,8 @@
#include "libGLESv2/utilities.h" #include "libGLESv2/utilities.h"
#include <limits> #include <limits>
#include <stdio.h>
#include <windows.h>
#include "common/debug.h" #include "common/debug.h"
...@@ -847,3 +849,36 @@ GLenum ConvertDepthStencilFormat(D3DFORMAT format) ...@@ -847,3 +849,36 @@ GLenum ConvertDepthStencilFormat(D3DFORMAT format)
} }
} }
std::string getTempPath()
{
char path[MAX_PATH];
DWORD pathLen = GetTempPathA(sizeof(path) / sizeof(path[0]), path);
if (pathLen == 0)
{
UNREACHABLE();
return std::string();
}
UINT unique = GetTempFileNameA(path, "sh", 0, path);
if (unique == 0)
{
UNREACHABLE();
return std::string();
}
return path;
}
void writeFile(const char* path, const void* content, size_t size)
{
FILE* file = fopen(path, "w");
if (!file)
{
UNREACHABLE();
return;
}
fwrite(content, sizeof(char), size, file);
fclose(file);
}
...@@ -14,6 +14,8 @@ ...@@ -14,6 +14,8 @@
#include <GLES2/gl2ext.h> #include <GLES2/gl2ext.h>
#include <d3d9.h> #include <d3d9.h>
#include <string>
namespace gl namespace gl
{ {
...@@ -78,4 +80,7 @@ GLenum ConvertDepthStencilFormat(D3DFORMAT format); ...@@ -78,4 +80,7 @@ GLenum ConvertDepthStencilFormat(D3DFORMAT format);
} }
std::string getTempPath();
void writeFile(const char* path, const void* data, size_t size);
#endif // LIBGLESV2_UTILITIES_H #endif // LIBGLESV2_UTILITIES_H
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment