Commit 105bc9d7 by Corentin Wallez Committed by Commit Bot

Revert "Allow enabling trace annotations"

This reverts commit f094bac9. Reason for revert: Causes timeouts on Debug bots in the BufferDataTest.NULLData Original change's description: > Allow enabling trace annotations > > Tracing was never allowed to happen because getStatus always returned > false. Also want to allow tracing for release builds for perf analysis. > > Bug: angleproject:3176 > Change-Id: I7aa94ed9fe3d7f67fe6dd10123c9badc7fb49d82 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1475248 > Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> > Reviewed-by: Jamie Madill <jmadill@google.com> TBR=ynovikov@chromium.org,geofflang@chromium.org,jmadill@google.com,courtneygo@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: angleproject:3176 Change-Id: I91d28d15a092519551811a9a07c01987c9e028e7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1505799Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
parent 2970d2b0
...@@ -200,7 +200,7 @@ config("angle_disable_pool_alloc") { ...@@ -200,7 +200,7 @@ config("angle_disable_pool_alloc") {
} }
config("debug_annotations_config") { config("debug_annotations_config") {
if (is_debug || angle_enable_trace) { if (is_debug) {
defines = [ "ANGLE_ENABLE_DEBUG_ANNOTATIONS" ] defines = [ "ANGLE_ENABLE_DEBUG_ANNOTATIONS" ]
} }
} }
......
...@@ -16,11 +16,7 @@ namespace angle ...@@ -16,11 +16,7 @@ namespace angle
bool LoggingAnnotator::getStatus() bool LoggingAnnotator::getStatus()
{ {
#if defined(ANGLE_TRACE_ENABLED)
return true;
#else
return false; return false;
#endif
} }
void LoggingAnnotator::beginEvent(const char *eventName, const char *eventMessage) void LoggingAnnotator::beginEvent(const char *eventName, const char *eventMessage)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment