Minor optimizations to DynamicHLSL.

This makes us use std::ostringstream in more places, instead of string concatenation. BUG=chromium:697758 Change-Id: Ifdcaa2e7e119664fc9cfdc566ea13b519a294714 Reviewed-on: https://chromium-review.googlesource.com/521729 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>

Minor optimizations to DynamicHLSL.
10bed9fc · Jamie Madill · Commit Bot · bb1e750c · 10bed9fc · 10bed9fc
Commit 10bed9fc authored Jun 05, 2017 by Jamie Madill Committed by Commit Bot Jun 06, 2017
Expand all Hide whitespace changes
Inline Side-by-side

Showing with 74 additions and 61 deletions

DynamicHLSL.cpp src/libANGLE/renderer/d3d/DynamicHLSL.cpp +70 -55

DynamicHLSL.h src/libANGLE/renderer/d3d/DynamicHLSL.h +4 -6

No files found.
--- a/src/libANGLE/renderer/d3d/DynamicHLSL.cpp
+++ b/src/libANGLE/renderer/d3d/DynamicHLSL.cpp
--- a/src/libANGLE/renderer/d3d/DynamicHLSL.h
+++ b/src/libANGLE/renderer/d3d/DynamicHLSL.h
@@ -147,13 +147,11 @@ class DynamicHLSL : angle::NonCopyable
    void generateVaryingLinkHLSL(const gl::VaryingPacking &varyingPacking,
                                 const BuiltinInfo &builtins,
                                 bool programUsesPointSize,
-                                 std::stringstream &hlslStream) const;
+                                 std::ostringstream &hlslStream) const;

-    // Prepend an underscore
-    static std::string decorateVariable(const std::string &name);
-
-    std::string generateAttributeConversionHLSL(gl::VertexFormatType vertexFormatType,
-                                                const sh::ShaderVariable &shaderAttrib) const;
+    static void GenerateAttributeConversionHLSL(gl::VertexFormatType vertexFormatType,
+                                                const sh::ShaderVariable &shaderAttrib,
+                                                std::ostringstream &outStream);
 };

 }  // namespace rx