Linux AMD crash when src blit region outside framebuffer

Linux AMD has a crash on an assert in the mesa driver that the source rectangle for blitFramebuffer be inside the framebuffer. Add Linux AMD to the existing workaround for this case. Note: this will duplicate some work on Linux AMD if the blit call is outside the framebuffer and also very large (the adjustSrcDstRegionBlitFramebuffer workaround) Bug: 1014370 Change-Id: I1afd1c92ab07dba6814d6b87ff7c3c19a19bdc0e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1953487 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>

Linux AMD crash when src blit region outside framebuffer
11e6944e · Jonah Ryan-Davis · Commit Bot · 4576f1d0 · 11e6944e
Commit 11e6944e authored Dec 05, 2019 by Jonah Ryan-Davis Committed by Commit Bot Dec 05, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

renderergl_utils.cpp src/libANGLE/renderer/gl/renderergl_utils.cpp +3 -2

No files found.
--- a/src/libANGLE/renderer/gl/renderergl_utils.cpp
+++ b/src/libANGLE/renderer/gl/renderergl_utils.cpp
@@ -1113,7 +1113,7 @@ void GenerateCaps(const FunctionsGL *functions,
                                    functions->hasGLExtension("GL_ARB_pixel_buffer_object") ||
                                    functions->hasGLExtension("GL_EXT_pixel_buffer_object") ||
                                    functions->hasGLESExtension("GL_NV_pixel_buffer_object");
-    extensions->glSync = nativegl::SupportsFenceSync(functions);
+    extensions->glSync    = nativegl::SupportsFenceSync(functions);
    extensions->mapBuffer = functions->isAtLeastGL(gl::Version(1, 5)) ||
                            functions->isAtLeastGLES(gl::Version(3, 0)) ||
                            functions->hasGLESExtension("GL_OES_mapbuffer");
@@ -1596,7 +1596,8 @@ void InitializeFeatures(const FunctionsGL *functions, angle::FeaturesGL *feature
    ANGLE_FEATURE_CONDITION(features, adjustSrcDstRegionBlitFramebuffer,
                            IsLinux() || (IsAndroid() && isNvidia) || (IsWindows() && isNvidia));

-    ANGLE_FEATURE_CONDITION(features, clipSrcRegionBlitFramebuffer, IsApple());
+    ANGLE_FEATURE_CONDITION(features, clipSrcRegionBlitFramebuffer,
+                            IsApple() || (IsLinux() && isAMD));

    ANGLE_FEATURE_CONDITION(features, resettingTexturesGeneratesErrors,
                            IsApple() || (IsWindows() && isAMD));