Vulkan: Move Feature init before device creation.

src/libANGLE/renderer/vulkan/RendererVk.cpp

@@ -454,6 +454,8 @@ vk::Error RendererVk::initialize(const egl::AttributeMap &attribs, const char *w
 
     ANGLE_VK_CHECK(graphicsQueueFamilyCount > 0, VK_ERROR_INITIALIZATION_FAILED);
 
+    initFeatures();
+
     // If only one queue family, go ahead and initialize the device. If there is more than one
     // queue, we'll have to wait until we see a WindowSurface to know which supports present.
     if (graphicsQueueFamilyCount == 1)
@@ -638,12 +640,23 @@ std::string RendererVk::getRendererDescription() const
     return strstr.str();
 }
 
+void RendererVk::initFeatures()
+{
+    // Use OpenGL line rasterization rules by default.
+    mFeatures.basicGLLineRasterization = true;
+
+    // For now, set this manually to true to enable viewport flipping. A couple of features are not
+    // working well like copyTexImage, copySubTexImage, blit, and probably some more. Until
+    // everything is fixed, we will keep the viewport flipping feature disabled.
+    mFeatures.flipViewportY = false;
+}
+
 void RendererVk::ensureCapsInitialized() const
 {
     if (!mCapsInitialized)
     {
         vk::GenerateCaps(mPhysicalDeviceProperties, mNativeTextureCaps, &mNativeCaps,
-                         &mNativeExtensions, &mNativeLimitations, &mFeatures);
+                         &mNativeExtensions, &mNativeLimitations);
         mCapsInitialized = true;
     }
 }

src/libANGLE/renderer/vulkan/RendererVk.h

@@ -148,6 +148,7 @@ class RendererVk : angle::NonCopyable
     vk::Error checkInFlightCommands();
     void freeAllInFlightResources();
     vk::Error flushCommandGraph(const gl::Context *context, vk::CommandBuffer *commandBatch);
+    void initFeatures();
 
     mutable bool mCapsInitialized;
     mutable gl::Caps mNativeCaps;

src/libANGLE/renderer/vulkan/vk_caps_utils.cpp

@@ -33,8 +33,7 @@ void GenerateCaps(const VkPhysicalDeviceProperties &physicalDeviceProperties,
                   const gl::TextureCapsMap &textureCaps,
                   gl::Caps *outCaps,
                   gl::Extensions *outExtensions,
-                  gl::Limitations * /* outLimitations */,
-                  FeaturesVk *features)
+                  gl::Limitations * /* outLimitations */)
 {
     outExtensions->setTextureExtensionSupport(textureCaps);
 
@@ -145,14 +144,6 @@ void GenerateCaps(const VkPhysicalDeviceProperties &physicalDeviceProperties,
     outCaps->maxVaryingVectors =
         (physicalDeviceProperties.limits.maxVertexOutputComponents / 4) - kReservedVaryingCount;
     outCaps->maxVertexOutputComponents = outCaps->maxVaryingVectors * 4;
-
-    // Use OpenGL line rasterization rules by default.
-    features->basicGLLineRasterization = true;
-
-    // For now, set this manually to true to enable viewport flipping. A couple of features are not
-    // working well like copyTexImage, copySubTexImage, blit, and probably some more. Until
-    // everything is fixed, we will keep the viewport flipping feature disabled.
-    features->flipViewportY = false;
 }
 }  // namespace vk
 

src/libANGLE/renderer/vulkan/vk_caps_utils.h

@@ -36,8 +36,7 @@ void GenerateCaps(const VkPhysicalDeviceProperties &physicalDeviceProperties,
                   const gl::TextureCapsMap &textureCaps,
                   gl::Caps *outCaps,
                   gl::Extensions *outExtensions,
-                  gl::Limitations * /* outLimitations */,
-                  FeaturesVk *features);
+                  gl::Limitations * /* outLimitations */);
 }  // namespace vk
 
 namespace egl_vk