Add GN arg to extract native libs in APK

Added GN bool arg "angle_extract_native_libs." When "false," which is the default, the native libs are zipped in the ANGLE apk. When true, the libs will be extracted which is useful when capturing flame graphs in order to see the ANGLE function names in your flamegraph. Bug: angleproject:4304 Change-Id: I86c91e5028688142b1137b859c800f2243c124d9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2028524Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Tobin Ehlis <tobine@google.com>

Add GN arg to extract native libs in APK
12c0e765 · Tobin Ehlis · Commit Bot · e4859ae5 · 12c0e765 · 12c0e765
Commit 12c0e765 authored Jan 29, 2020 by Tobin Ehlis Committed by Commit Bot Jan 29, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 2 deletions

AndroidManifest.xml.jinja2 android/AndroidManifest.xml.jinja2 +1 -1

angle_apk.gni android/angle_apk.gni +4 -1

angle.gni gni/angle.gni +3 -0

No files found.
--- a/android/AndroidManifest.xml.jinja2
+++ b/android/AndroidManifest.xml.jinja2
@@ -10,7 +10,7 @@
          package="{{manifest_package|default('com.chromium.angle')}}">
    <application android:label="Angle for Android"
-                 android:extractNativeLibs="false"
+                 android:extractNativeLibs="{{extract_native_libs|default('false')}}"
                 android:multiArch="true">
    </application>
 </manifest>
--- a/android/angle_apk.gni
+++ b/android/angle_apk.gni
@@ -23,7 +23,10 @@ if (enable_java_templates) {
    jinja_template(manifest_target_name) {
      input = "//third_party/angle/android/AndroidManifest.xml.jinja2"
      output = manifest_path
-      variables = [ "manifest_package=${invoker.package_name}" ]
+      variables = [
+        "manifest_package=${invoker.package_name}",
+        "extract_native_libs=${angle_extract_native_libs}",
+      ]
    }
    android_assets("${invoker.package_name}_assets") {

--- a/gni/angle.gni
+++ b/gni/angle.gni
@@ -6,6 +6,9 @@ import("//build_overrides/angle.gni")
 declare_args() {
  is_ggp = false
+  # Extract native libs in ANGLE apk. Useful for flamegraph generation.
+  angle_extract_native_libs = false
 }
 if (angle_has_build) {