Enable unneeded-internal-declaration compiler warning

No longer have issues with unneeded internal declarations now that Tokenizer.cpp has been updated so re-enable compiler warning to catch future issues. BUG:angleproject:2451 Test: build Change-Id: I30daadc8c7374bcae753a7e69cb9a72855a1f548 Reviewed-on: https://chromium-review.googlesource.com/1007965 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>

Enable unneeded-internal-declaration compiler warning
15215261 · Courtney Goeltzenleuchter · Commit Bot · 51dd886b · 15215261 · 15215261
Commit 15215261 authored Apr 11, 2018 by Courtney Goeltzenleuchter Committed by Commit Bot Apr 13, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 0 deletions

BUILD.gn BUILD.gn +1 -0

glslang.l src/compiler/translator/glslang.l +1 -0

glslang_lex.cpp src/compiler/translator/glslang_lex.cpp +1 -0

No files found.
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -99,6 +99,7 @@ config("extra_warnings") {
    cflags += [
      # Remove when crbug.com/428099 is resolved.
      "-Winconsistent-missing-override",
+      "-Wunneeded-internal-declaration",
    ]
  }
 }

--- a/src/compiler/translator/glslang.l
+++ b/src/compiler/translator/glslang.l
@@ -66,6 +66,7 @@ using namespace sh;
 #endif
 #endif
+#define YY_NO_INPUT
 #define YY_USER_ACTION                                 \
    yylloc->first_file = yylloc->last_file = yycolumn; \
    yylloc->first_line = yylloc->last_line = yylineno;

--- a/src/compiler/translator/glslang_lex.cpp
+++ b/src/compiler/translator/glslang_lex.cpp
@@ -1205,6 +1205,7 @@ using namespace sh;
 #endif
 #endif
+#define YY_NO_INPUT
 #define YY_USER_ACTION                                 \
    yylloc->first_file = yylloc->last_file = yycolumn; \
    yylloc->first_line = yylloc->last_line = yylineno;