Skip to content

A
angle
Commit 16c993c3 by Gert Wollny Committed by Angle LUCI CQ
Options

Capture/Replay: Only capture initialized renderbuffer content

Enable the DepthStencilTest.* that was failing before. Bug: angleproject:6094 Change-Id: I8c69de4927c0e70143cd632e97f0abdb740a013f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2982550 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarCody Northrop <cnorthrop@google.com>
parent e78b1bf1
Showing with 14 additions and 7 deletions
src/libANGLE/capture/frame_capture_utils.cpp
...@@ -866,12 +866,20 @@ Result SerializeRenderbuffer(const gl::Context *context, ...@@ -866,12 +866,20 @@ Result SerializeRenderbuffer(const gl::Context *context,
ANGLE_CHECK_GL_ALLOC( ANGLE_CHECK_GL_ALLOC(
const_cast<gl::Context *>(context), const_cast<gl::Context *>(context),
scratchBuffer->getInitialized(renderbuffer->getMemorySize(), &pixelsPtr, 0)); scratchBuffer->getInitialized(renderbuffer->getMemorySize(), &pixelsPtr, 0));
gl::PixelPackState packState;
packState.alignment = 1; if (renderbuffer->initState(gl::ImageIndex()) == gl::InitState::Initialized)
ANGLE_TRY(renderbuffer->getImplementation()->getRenderbufferImage( {
context, packState, nullptr, renderbuffer->getImplementationColorReadFormat(context), gl::PixelPackState packState;
renderbuffer->getImplementationColorReadType(context), pixelsPtr->data())); packState.alignment = 1;
json->addBlob("pixel", pixelsPtr->data(), pixelsPtr->size()); ANGLE_TRY(renderbuffer->getImplementation()->getRenderbufferImage(
context, packState, nullptr, renderbuffer->getImplementationColorReadFormat(context),
renderbuffer->getImplementationColorReadType(context), pixelsPtr->data()));
json->addBlob("pixel", pixelsPtr->data(), pixelsPtr->size());
}
else
{
json->addCString("pixel", "Not initialized");
}
return Result::Continue; return Result::Continue;
} }
......
src/tests/capture_replay_tests/capture_replay_expectations.txt
...@@ -31,7 +31,6 @@ ClipDistanceTest.* ...@@ -31,7 +31,6 @@ ClipDistanceTest.*
CopyCompressedTextureTest.InternalFormat/* CopyCompressedTextureTest.InternalFormat/*
DebugMarkerTest.* DebugMarkerTest.*
DebugTest.* DebugTest.*
DepthStencilTest.*
EGLPrintEGLinfoTest.PrintGLESCapabilities/* EGLPrintEGLinfoTest.PrintGLESCapabilities/*
EGLStreamTest.* EGLStreamTest.*
ExternalWrapTest.* ExternalWrapTest.*
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment