Skip to content

A
angle
Commit 16dbcc13 by Ian Elliott Committed by Commit Bot
Options

dEQP: Avoid undefined right-shift behavior for GLhalf

The FloatToHalf() function in "es31cVertexAttribBindingTests.cpp" will attempt to right-shift more than the number of bits in an integer (i.e. by 70) when converting 0.0f to GLhalf. Bug: angleproject:5500 Change-Id: I587e71a2cb1377b95ed74a1bba5f4ceef6a4a516 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2618665 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarYuly Novikov <ynovikov@chromium.org>
parent cb71062a
Showing with 6 additions and 6 deletions
src/tests/deqp_support/deqp.gni
...@@ -1187,8 +1187,13 @@ deqp_khr_gles31_sources = [ ...@@ -1187,8 +1187,13 @@ deqp_khr_gles31_sources = [
"$deqp_path/external/openglcts/modules/gles31/es31cTextureStorageMultisampleTexStorage2DMultisampleTests.hpp", "$deqp_path/external/openglcts/modules/gles31/es31cTextureStorageMultisampleTexStorage2DMultisampleTests.hpp",
"$deqp_path/external/openglcts/modules/gles31/es31cTextureStorageMultisampleTexStorage3DMultisampleTests.cpp", "$deqp_path/external/openglcts/modules/gles31/es31cTextureStorageMultisampleTexStorage3DMultisampleTests.cpp",
"$deqp_path/external/openglcts/modules/gles31/es31cTextureStorageMultisampleTexStorage3DMultisampleTests.hpp", "$deqp_path/external/openglcts/modules/gles31/es31cTextureStorageMultisampleTexStorage3DMultisampleTests.hpp",
"$deqp_path/external/openglcts/modules/gles31/es31cVertexAttribBindingTests.cpp",
# "$deqp_path/external/openglcts/modules/gles31/es31cVertexAttribBindingTests.cpp",
"$deqp_path/external/openglcts/modules/gles31/es31cVertexAttribBindingTests.hpp", "$deqp_path/external/openglcts/modules/gles31/es31cVertexAttribBindingTests.hpp",
# Overrides
# 5500: Override to prevent right-shifts by too large a value
"deqp_support/es31cVertexAttribBindingTests_override.cpp",
] ]
deqp_khr_gles32_sources = [ deqp_khr_gles32_sources = [
......
src/tests/deqp_support/deqp_khr_gles31_test_expectations.txt
...@@ -126,7 +126,3 @@ ...@@ -126,7 +126,3 @@
// New failures with latest dEQP roll (2020-04-28) // New failures with latest dEQP roll (2020-04-28)
4593 SWIFTSHADER : KHR-GLES31.core.nearest_edge.offset_left = FAIL 4593 SWIFTSHADER : KHR-GLES31.core.nearest_edge.offset_left = FAIL
// Started failing on SwANGLE and Pixel 2 Vulkan after clang roll
5500 SWIFTSHADER : KHR-GLES31.core.vertex_attrib_binding.basic-input-case5 = FAIL
5500 VULKAN PIXEL2ORXL : KHR-GLES31.core.vertex_attrib_binding.basic-input-case5 = FAIL
\ No newline at end of file
src/tests/deqp_support/es31cVertexAttribBindingTests_override.cpp 0 → 100644
This source diff could not be displayed because it is too large. You can view the blob instead.
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment