Fix assert when attempting to create a void array node

src/compiler/translator/IntermNode.cpp

@@ -564,8 +564,6 @@ TIntermTyped *TIntermTyped::CreateZero(const TType &type)
 
     if (!type.isArray() && type.getBasicType() != EbtStruct)
     {
-        ASSERT(type.isScalar() || type.isVector() || type.isMatrix());
-
         size_t size       = constType.getObjectSize();
         TConstantUnion *u = new TConstantUnion[size];
         for (size_t i = 0; i < size; ++i)
@@ -599,6 +597,15 @@ TIntermTyped *TIntermTyped::CreateZero(const TType &type)
         return node;
     }
 
+    if (type.getBasicType() == EbtVoid)
+    {
+        // Void array. This happens only on error condition, similarly to the case above. We don't
+        // have a constructor operator for void, so this needs special handling. We'll end up with a
+        // value without the array type, but that should not be a problem.
+        constType.clearArrayness();
+        return CreateZero(constType);
+    }
+
     TIntermSequence *arguments = new TIntermSequence();
 
     if (type.isArray())

src/tests/compiler_tests/ShaderValidation_test.cpp

@@ -3707,3 +3707,25 @@ TEST_F(FragmentShaderValidationTest, SamplerUniformBindingESSL300)
         FAIL() << "Shader compilation succeeded, expecting failure " << mInfoLog;
     }
 }
+
+// Attempting to construct a struct containing a void array should fail without asserting.
+TEST_F(FragmentShaderValidationTest, ConstructStructContainingVoidArray)
+{
+    const std::string &shaderString =
+        "#version 300 es\n"
+        "precision mediump float;\n"
+        "out vec4 outFrag;\n"
+        "struct S\n"
+        "{\n"
+        "    void A[1];\n"
+        "} s = S();\n"
+        "void main()\n"
+        "{\n"
+        "    outFrag = vec4(0.0);\n"
+        "}\n";
+
+    if (compile(shaderString))
+    {
+        FAIL() << "Shader compilation succeeded, expecting failure " << mInfoLog;
+    }
+}