GLES1: disable texture3DOES extension

It requires GLES 2.0+ This should help keep src/tests/gl_tests/gles1/TextureParameterTest.cpp: TextureParameterTest.NegativeEnum green even if the extension is propagated to the frontend from the underlying renderer. Bug: angleproject:3639 Change-Id: I04118e060f38cb774a6897ee6ce035b540a3b60e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1686822Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Lingfeng Yang <lfy@google.com>

GLES1: disable texture3DOES extension
196cd9e7 · Lingfeng Yang · Commit Bot · 7356514a · 196cd9e7 · 196cd9e7
Commit 196cd9e7 authored Jul 03, 2019 by Lingfeng Yang Committed by Commit Bot Jul 03, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 4 deletions

Context.cpp src/libANGLE/Context.cpp +1 -0

TextureParameterTest.cpp src/tests/gl_tests/gles1/TextureParameterTest.cpp +0 -4

No files found.
--- a/src/libANGLE/Context.cpp
+++ b/src/libANGLE/Context.cpp
@@ -3161,6 +3161,7 @@ Extensions Context::generateSupportedExtensions() const
        supportedExtensions.pointSprite           = true;
        supportedExtensions.drawTexture           = true;
        supportedExtensions.parallelShaderCompile = false;
+        supportedExtensions.texture3DOES          = false;
    }

    if (getClientVersion() < ES_3_0)

--- a/src/tests/gl_tests/gles1/TextureParameterTest.cpp
+++ b/src/tests/gl_tests/gles1/TextureParameterTest.cpp
@@ -67,10 +67,6 @@ TEST_P(TextureParameterTest, InitialState)
 // Negative test: invalid enum / operation
 TEST_P(TextureParameterTest, NegativeEnum)
 {
-    // The texture3d query below appears to be broken on all configs
-    // anglebug.com/3639
-    ANGLE_SKIP_TEST_IF(true);
-
    // Invalid target (not supported)
    glGetTexParameteriv(GL_TEXTURE_3D, GL_TEXTURE_MIN_FILTER, nullptr);
    EXPECT_GL_ERROR(GL_INVALID_ENUM);