Fix the misuse of deepCopy()

When we use replaceChildNode function, the first argument must be the original child node instead of the deepCopy. Otherwise, replaceChildNode will do nothing since it will think deepCopy is a different node. In that case, RewriteExpressionsWithShaderStorageBlockTraverser::visitAggregate will enter an endless loop since ssbo argument is never really replaced. Test: dEQP-GLES31.functional.ssbo.* Bug: angleproject:1951 Change-Id: Ieb17a16ab2b3e0270328fafd7ba0944ca05f842f Reviewed-on: https://chromium-review.googlesource.com/c/1446686Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>

Fix the misuse of deepCopy()
1a07524d · Qin Jiajia · Commit Bot · 48d040e8 · 1a07524d
Commit 1a07524d authored Jan 31, 2019 by Qin Jiajia Committed by Commit Bot Feb 01, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

RewriteExpressionsWithShaderStorageBlock.cpp ...tor/tree_ops/RewriteExpressionsWithShaderStorageBlock.cpp +1 -1

No files found.
--- a/src/compiler/translator/tree_ops/RewriteExpressionsWithShaderStorageBlock.cpp
+++ b/src/compiler/translator/tree_ops/RewriteExpressionsWithShaderStorageBlock.cpp
@@ -302,7 +302,7 @@ bool RewriteExpressionsWithShaderStorageBlockTraverser::visitAggregate(Visit vis
                    readBackToSSBOs.push_back(readBackToSSBO);
                }
            }
-            node->replaceChildNode(ssboArgument->deepCopy(), argumentCopy);
+            node->replaceChildNode(ssboArgument, argumentCopy);
        }
    }