Add const to optional parameters of SPIR-V instruction builders

Bug: angleproject:4888 Change-Id: I70274042794a7d56db48490d9e3930e1eace02bf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2713267Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Add const to optional parameters of SPIR-V instruction builders
1a70e5a0 · Shahbaz Youssefi · Commit Bot · c2d14d03 · 1a70e5a0 · 1a70e5a0
Commit 1a70e5a0 authored Feb 22, 2021 by Shahbaz Youssefi Committed by Commit Bot Feb 22, 2021
4 changed files
--- a/scripts/code_generation_hashes/SPIR-V_helpers.json
+++ b/scripts/code_generation_hashes/SPIR-V_helpers.json
 {
  "src/common/spirv/gen_spirv_builder_and_parser.py":
-    "02381e3a7cf898265de3ba438b3b6e5e",
+    "4c57f0814056b5b5e80494380854371f",
  "src/common/spirv/spirv_instruction_builder_autogen.cpp":
-    "b9c0c27ab2de86955528d4d8ba9be817",
+    "6ea97ca168ecccb4a621a06446e4933a",
  "src/common/spirv/spirv_instruction_builder_autogen.h":
-    "9629f02ff30720ec38a9aad0fc5c1503",
+    "aa4980783495c40873598156b02b7784",
  "src/common/spirv/spirv_instruction_parser_autogen.cpp":
    "55d28bb4b003dbecf31e162ff996fc4f",
  "src/common/spirv/spirv_instruction_parser_autogen.h":

--- a/src/common/spirv/gen_spirv_builder_and_parser.py
+++ b/src/common/spirv/gen_spirv_builder_and_parser.py
@@ -301,7 +301,7 @@ class Writer:
            type_in = 'const ' + cpp_type + 'List &'
            type_out = cpp_type + 'List *'
        elif is_optional:
-            type_in = cpp_type + ' *'
+            type_in = 'const ' + cpp_type + ' *'
            type_out = cpp_type + ' *'
        else:
            type_in = cpp_type

--- a/src/common/spirv/spirv_instruction_builder_autogen.cpp
+++ b/src/common/spirv/spirv_instruction_builder_autogen.cpp
--- a/src/common/spirv/spirv_instruction_builder_autogen.h
+++ b/src/common/spirv/spirv_instruction_builder_autogen.h