Fix assignment of CacheOpResult::EnumCount

The special enum value 'EnumCount' is used by EnumSize() to determine how large to make the PackedEnumMap::mPrivateData array. However, that enum entry was being assigned an incorrect value, leading to the array being constructed too small and causing a crash in PackedEnumMap's std::initializer_list constructor when it went beyond the size of the array to assign each of the necessary values. The fix is to remove the assignment of CacheOpResult::EnumCount and let it indicate the real number of entries in the enum. Bug: angleproject:4393 Test: end2end Change-Id: If9635c61e72aadc6527d416f83be18add8b24572 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050026Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>

Fix assignment of CacheOpResult::EnumCount
1a8b7758 · Tim Van Patten · Commit Bot · b40d48a6 · 1a8b7758
Commit 1a8b7758 authored Feb 11, 2020 by Tim Van Patten Committed by Commit Bot Feb 11, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

EGLBlobCacheTest.cpp src/tests/egl_tests/EGLBlobCacheTest.cpp +1 -1

No files found.
--- a/src/tests/egl_tests/EGLBlobCacheTest.cpp
+++ b/src/tests/egl_tests/EGLBlobCacheTest.cpp
@@ -28,7 +28,7 @@ enum class CacheOpResult
    GetMemoryTooSmall,
    GetSuccess,
    ValueNotSet,
-    EnumCount = ValueNotSet,
+    EnumCount
 };
 angle::PackedEnumMap<CacheOpResult, std::string> kCacheOpToString = {